Spec URL: https://git.remirepo.net/cgit/rpms/php/composer/php-composer-pcre.git/plain/php-composer-pcre.spec?id=2e32223b4a5a5cd2f24cc0350230d95794ef22dc SRPM URL: https://rpms.remirepo.net/SRPMS/php-composer-pcre-1.0.0-1.remi.src.rpm Description: PCRE wrapping library that offers type-safe preg_* replacements. This library gives you a way to ensure preg_* functions do not fail silently, returning unexpected nulls that may not be handled. It also makes it easier ot work with static analysis tools like PHPStan or Psalm as it simplifies and reduces the possible return values from all the preg_* functions which are quite packed with edge cases. Fedora Account System Username: remi --- new dependency of upcoming composer 2.2 (and of composer/xdebug-handler)
I ran fedora-review on the package, will complete the full review shortly. One easy to fix nit: php-composer-pcre.src: W: strange-permission makesrc.sh 775 I also had some trouble with makesrc.sh as the resulting local tar has not the same sha256sum as the one in the srpm, but will dive in more detail. Probably due to timestamp on files as the .gitattributes prevents using the GitHub tar directly. Ugh.
> php-composer-pcre.src: W: strange-permission makesrc.sh 775 only a warning, and expected, to be able to run it ;)
Package Approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 36 files have unknown license. Detailed output of licensecheck in /home/fedora/2030376-php-composer- pcre/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/Composer(composer, php-composer-xdebug-handler, php- composer-xdebug-handler2, php-composer-spdx-licenses, php-composer- semver3, php-composer-metadata-minifier, php-composer-ca-bundle) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: Data Source Analysed Directories 4 Files 29 Errors 0 Extensions Analysis Extension REF EXT min/Max PHP min/Max core core 5.2.7 5.2.7 pcre pcre 8.0.0 8.0.0RC2 spl spl 5.1.0 5.3.0 standard standard 4.0.0 4.0.0 Total [4] 8.0.0RC2 Namespaces Analysis Namespace REF EXT min/Max PHP min/Max Composer\Pcre core 8.0.0 8.0.0RC2 Composer\Pcre\PregTests user 5.3.0 Composer\Pcre\RegexTests user 5.3.0 Total [3] 8.0.0RC2 No interface found No trait found Classes Analysis Class REF EXT min/Max PHP min/Max Composer\Pcre\BaseTestCase standard 4.0.0 5.3.0 Composer\Pcre\MatchAllResult user 5.3.0 Composer\Pcre\MatchAllWithOffsetsResult user 5.3.0 U Composer\Pcre\MatchResult user 5.3.0 Composer\Pcre\MatchWithOffsetsResult user 5.3.0 Composer\Pcre\PcreException core 8.0.0 8.0.0RC2 Composer\Pcre\Preg pcre 7.0.0 7.4.0 Composer\Pcre\PregTests\GrepTest user 5.3.0 Composer\Pcre\PregTests\IsMatchAllTest user 5.3.0 Composer\Pcre\PregTests\IsMatchAllWithOffsetsTest user 5.3.0 Composer\Pcre\PregTests\IsMatchTest user 5.3.0 Composer\Pcre\PregTests\IsMatchWithOffsetsTest user 5.3.0 Composer\Pcre\PregTests\MatchAllTest user 5.3.0 Composer\Pcre\PregTests\MatchTest user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackArrayTest user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest user 5.3.0 Composer\Pcre\PregTests\ReplaceTest user 5.3.0 Composer\Pcre\PregTests\SplitTest user 5.3.0 Composer\Pcre\PregTests\SplitWithOffsetsTest user 5.3.0 Composer\Pcre\Regex user 5.3.0 Composer\Pcre\RegexTests\IsMatchTest user 5.3.0 Composer\Pcre\RegexTests\MatchAllTest user 5.3.0 Composer\Pcre\RegexTests\MatchAllWithOffsetsTest user 5.3.0 Composer\Pcre\RegexTests\MatchTest user 5.3.0 Composer\Pcre\RegexTests\MatchWithOffsetsTest user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackArrayTest user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackTest user 5.3.0 Composer\Pcre\RegexTests\ReplaceTest user 5.3.0 Composer\Pcre\ReplaceResult user 5.3.0 InvalidArgumentException spl 5.1.0 5.1.0 CU PHPUnit\Framework\Error\Warning user 0.1.0 4.0.0 U array user 4.0.0 Total [32] 8.0.0RC2 No generator found Functions Analysis Function REF EXT min/Max PHP min/Max Composer\Pcre\PregTests\ReplaceCallbackArrayTest\testBadPatternThrowsIfWarningsAreNotThrowing\closure-78-80 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackArrayTest\testBadPatternTriggersWarningByDefault\closure-90-92 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackArrayTest\testFailure\closure-63-65 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackArrayTest\testSuccessNoRef\closure-51-53 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackArrayTest\testSuccess\closure-38-40 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackArrayTest\testThrowsWithSubjectArray\closure-102-104 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest\testBadPatternThrowsIfWarningsAreNotThrowing\closure-75-77 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest\testBadPatternTriggersWarningByDefault\closure-87-89 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest\testFailure\closure-60-62 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest\testSuccessNoRef\closure-48-50 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest\testSuccess\closure-35-37 user 5.3.0 Composer\Pcre\PregTests\ReplaceCallbackTest\testThrowsWithSubjectArray\closure-99-101 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackArrayTest\testBadPatternThrowsIfWarningsAreNotThrowing\closure-71-73 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackArrayTest\testBadPatternTriggersWarningByDefault\closure-83-85 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackArrayTest\testFailure\closure-54-56 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackArrayTest\testSuccess\closure-39-41 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackArrayTest\testThrowsWithSubjectArray\closure-95-97 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackTest\testBadPatternThrowsIfWarningsAreNotThrowing\closure-68-70 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackTest\testBadPatternTriggersWarningByDefault\closure-80-82 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackTest\testFailure\closure-51-53 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackTest\testSuccess\closure-36-38 user 5.3.0 Composer\Pcre\RegexTests\ReplaceCallbackTest\testThrowsWithSubjectArray\closure-92-94 user 5.3.0 array_keys standard 4.0.0 4.0.0 class_exists core 4.0.0 4.0.0 get_defined_constants core 4.0.7 4.0.7 implode standard 4.0.0 4.0.0 is_array standard 4.0.0 4.0.0 method_exists core 4.0.0 4.0.0 preg_grep pcre 4.0.0 4.0.0 preg_last_error pcre 5.2.0 5.2.0 preg_last_error_msg pcre 8.0.0 8.0.0RC2 preg_match pcre 4.0.0 4.0.0 preg_match_all pcre 4.0.0 4.0.0 preg_replace pcre 4.0.0 5.1.0 preg_replace_callback pcre 4.0.5 7.4.0 preg_replace_callback_array pcre 7.0.0 7.0.0alpha1 preg_split pcre 4.0.0 4.0.0 sprintf standard 4.0.0 4.0.0 substr standard 4.0.0 4.0.0 Total [39] 8.0.0RC2 Constants Analysis Constant REF EXT min/Max PHP min/Max Composer\Pcre\Preg\ARRAY_MSG user 4.0.0 PHP_VERSION_ID core 5.2.7 5.2.7 PREG_OFFSET_CAPTURE pcre 4.3.0 4.3.0 PREG_SET_ORDER pcre 4.0.0 4.0.0 PREG_SPLIT_OFFSET_CAPTURE pcre 4.3.0 4.3.0 false core 4.0.0 4.0.0 null core 4.0.0 4.0.0 true core 4.0.0 4.0.0 Total [8] 5.2.7 Conditions Analysis Condition REF EXT min/Max PHP min/Max class_exists(PHPUnit\Framework\Error\Warning) user 0.1.0 4.0.0 Total [1] 4.0.0 Requires PHP 8.0.0RC2 (min) Profile results are being logged as JSON format to /home/fedora/2030376-php-composer-pcre/phpci.log phpCompatInfo version 5.5.3 DB version 3.14.0 static analyze results in /home/fedora/2030376-php-composer-pcre/phpci.log Rpmlint ------- Checking: php-composer-pcre-1.0.0-1.fc36.noarch.rpm php-composer-pcre-1.0.0-1.fc36.src.rpm php-composer-pcre.noarch: W: spelling-error %description -l en_US preg -> grep, pref, peg php-composer-pcre.noarch: W: spelling-error %description -l en_US ot -> OT, to, it php-composer-pcre.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-composer-pcre.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-composer-pcre.src: W: spelling-error %description -l en_US preg -> grep, pref, peg php-composer-pcre.src: W: spelling-error %description -l en_US ot -> OT, to, it php-composer-pcre.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-composer-pcre.src: W: spelling-error %description -l en_US usr -> use, us, user php-composer-pcre.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-composer-pcre.src: W: strange-permission makesrc.sh 775 php-composer-pcre.src: W: invalid-url Source0: php-composer-pcre-1.0.0-3d322d7.tgz 2 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- php-composer-pcre (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-pcre php-spl Provides -------- php-composer-pcre: php-composer(composer/pcre) php-composer-pcre Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2030376 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, PHP Disabled plugins: Haskell, R, Perl, Python, fonts, C/C++, Java, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the fast review SCM Requests https://pagure.io/releng/fedora-scm-requests/issue/39285 https://pagure.io/releng/fedora-scm-requests/issue/39286 https://pagure.io/releng/fedora-scm-requests/issue/39287
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-composer-pcre
FEDORA-2021-71b4a50efd has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-71b4a50efd
FEDORA-2021-e364fa9430 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e364fa9430 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e364fa9430 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-71b4a50efd has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-71b4a50efd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-71b4a50efd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-71b4a50efd has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-e364fa9430 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.