Bug 2030406 - Dynamic plugin demo nav outputs incorrect markup that doesn't conform to the Console navigation which uses the PatternFly Navigation component
Summary: Dynamic plugin demo nav outputs incorrect markup that doesn't conform to the ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.12.0
Assignee: Yadan Pei
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-08 17:24 UTC by Steve Goodwin
Modified: 2023-01-17 19:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
No end user impact.
Clone Of:
Environment:
Last Closed: 2023-01-17 19:46:49 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
nav html (124.90 KB, image/png)
2022-10-17 08:21 UTC, Yadan Pei
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 12079 0 None open Bug 2030406: Remove nav override for fixed demo plugin nav component dom structure 2022-09-21 19:18:46 UTC
Red Hat Product Errata RHSA-2022:7399 0 None None None 2023-01-17 19:47:09 UTC

Description Steve Goodwin 2021-12-08 17:24:33 UTC
The Dynamic plugin demo nav outputs incorrect markup that doesn't conform to the Web Console which uses PatternFly Navigation markup and css to display correctly.
So custom override css is needed for it to display with list bullets https://github.com/openshift/console/pull/10412#discussion_r765007664

The markup should match the existing Web Console markup and css so that no custom css is needed.

Actual markup results:
<div class="oc-perspective-nav">
  <div><li class="pf-c-nav__item>...</li></div>
  <div><li class="pf-c-nav__item>...</li></div>
  ...
</div>

Expected results:
<div class="oc-perspective-nav">
  <ul class="pf-c-nav__list">
    <li class="pf-c-nav__item>...</li>
    <li class="pf-c-nav__item>...</li>
    ...
  </ul>
</div>


https://www.patternfly.org/v4/components/navigation/html#default

Comment 4 Yadan Pei 2022-10-17 08:21:22 UTC
Created attachment 1918481 [details]
nav html

Demo Plugin nav use correct markup that conform to console navigation style

verified on 4.12.0-0.nightly-2022-10-15-094115

Comment 7 errata-xmlrpc 2023-01-17 19:46:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7399


Note You need to log in before you can comment on or make changes to this bug.