Bug 2031169 - Review Request: rust-crypto-bigint - Pure Rust bigint implementation for use in cryptographic applications
Summary: Review Request: rust-crypto-bigint - Pure Rust bigint implementation for use ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Trystram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-10 16:40 UTC by Fabio Valentini
Modified: 2021-12-13 17:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-13 17:14:45 UTC
Type: ---
Embargoed:
jbtrystram: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2021-12-10 16:40:25 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-crypto-bigint.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-crypto-bigint-0.2.11-1.fc35.src.rpm

Description:
Pure Rust implementation of a big integer library which has been designed from
the ground-up for use in cryptographic applications. Provides constant-time,
no_std-friendly implementations of modern formulas using const generics.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-10 16:40:28 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79794639

Comment 2 Trystram 2021-12-13 13:49:51 UTC
The package looks good to me but the latest release upstream is 0.3.2. If I am correct this is a dependency for the DER package, but should we plan to package both versions? 
I'll try to see if der builds using the latest release.

Comment 3 Fabio Valentini 2021-12-13 15:41:21 UTC
I forgot to mention that I actually packaged the most recent version that is compatible with what we will need.

Updating the whole RustCrypto stack to the slew of updates that was released over the past week will come later, when I have time to adapt the dependent packages - getting new packages in is higher priority right now, since nothing actually depends on the new versions yet.

Comment 4 Trystram 2021-12-13 15:55:20 UTC
> Updating the whole RustCrypto stack to the slew of updates that was released
> over the past week will come later

That works for me. I'll be happy to help with updating some packages later on if you want to share the load. 



Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fabio Valentini 2021-12-13 16:17:18 UTC
Thanks for the review!

I'll work on adding and updating the rest of the packages soon, but I'm waiting for a response here first:
https://bugzilla.redhat.com/show_bug.cgi?id=1981121#c1

Comment 6 Gwyn Ciesla 2021-12-13 16:25:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crypto-bigint


Note You need to log in before you can comment on or make changes to this bug.