Bug 2031365 - Review Request: rit-rachana-fonts - OpenType font for Malayalam script
Summary: Review Request: rit-rachana-fonts - OpenType font for Malayalam script
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2021-12-11 10:53 UTC by Rajeesh
Modified: 2021-12-22 13:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-12-22 13:33:40 UTC
Type: ---
panemade: fedora-review+

Attachments (Terms of Use)

Description Rajeesh 2021-12-11 10:53:24 UTC
Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-rachana-fonts.spec
SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-rachana-fonts-1.3-1.fc35.src.rpm
Description: RIT Rachana traditional orthography opentype font with definitive character set for Malayalam
Fedora Account System Username: rajeeshknambiar

NOTE: this package obsoletes smc-rachana-fonts (discussed with vvijayara and pravins).

Comment 1 Parag Nemade 2021-12-18 04:56:55 UTC
I prefer different bugzilla account for package reviews.

Comment 2 Parag AN(पराग) 2021-12-20 07:44:16 UTC
Review Suggestion:
1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file
BuildRequires:    fontpackages-devel
Requires:    fontpackages-filesystem

2) Change below from
%global fontfamily rit-rachana
%global fontfamily RIT Rachana

Please fix this before importing this package in Fedora.

Rest of the packaging looks good to me.

APPROVED this package.

Comment 3 Rajeesh 2021-12-20 10:03:14 UTC
Thanks for the review and approval!

I have uploaded the updated SPEC: https://rajeeshknambiar.fedorapeople.org/spec/rit-rachana-fonts.spec

Comment 4 Parag AN(पराग) 2021-12-21 03:08:03 UTC
Same here.
The only thing remaining here is that this new package is not obsoleting existing smc-meera-fonts package. Fix this by changing
Obsoletes:   smc-rachana-fonts <= 7.0
Obsoletes:   smc-rachana-fonts <= 7.0.3

Rest looks good to me.

Comment 5 Gwyn Ciesla 2021-12-21 15:38:09 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rit-rachana-fonts

Note You need to log in before you can comment on or make changes to this bug.