Bug 2031377 - Review Request: rit-tn-joy-fonts - A traditional orthography font for Malayalam script
Summary: Review Request: rit-tn-joy-fonts - A traditional orthography font for Malayal...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-11 12:36 UTC by Rajeesh
Modified: 2021-12-28 13:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-28 13:48:31 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Rajeesh 2021-12-11 12:36:36 UTC
Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-tnjoy-fonts.spec
SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-tnjoy-fonts-1.4-0.fc35.src.rpm
Description: A traditional orthography Malayalam Unicode font
Fedora Account System Username: rajeeshknambiar

Comment 1 Parag Nemade 2021-12-18 04:56:55 UTC
I prefer different bugzilla account for package reviews.

Comment 2 Parag AN(पराग) 2021-12-22 15:25:45 UTC
Review Suggestion:
1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file
BuildRequires:    fontpackages-devel
Requires:    fontpackages-filesystem

2) New fonts packaging guidelines need the font family name as its written in font file. For this package its "TN Joy" and the font package name will be <foundry>-<FontFamily>-fonts. Thus for this package its rit-tn-joy-fonts.

3) Submit new SPEC and SRPM links.

4) conf file path is empty in SPEC. Change
%global fontconfs %{nil}
to
%global fontconfs meta/67-tnjoy-fonts.conf

5) Also, you need to change the "TNJoy" to "TN Joy" in 67-tnjoy-fonts.conf file. As the Font family to match is "TN Joy".

Comment 3 Rajeesh 2021-12-22 17:01:42 UTC
Thank you.

A new upstream release is also made, and SPEC+SRPM updated.

SPEC: https://rajeeshknambiar.fedorapeople.org/spec/rit-tn-joy-fonts.spec
SRPM: https://rajeeshknambiar.fedorapeople.org/srpm/rit-tn-joy-fonts-1.4.1-0.fc35.src.rpm

Comment 4 Parag AN(पराग) 2021-12-23 06:04:03 UTC
Thank you for the update. The changes looks good to me.

APPROVED.

Comment 5 Gwyn Ciesla 2021-12-27 16:53:29 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rit-tn-joy-fonts


Note You need to log in before you can comment on or make changes to this bug.