Bug 2031855 - linuxscsi: Only raise and log multipathd errors when required
Summary: linuxscsi: Only raise and log multipathd errors when required
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-os-brick
Version: 16.2 (Train)
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: z2
: 16.2 (Train on RHEL 8.4)
Assignee: Alan Bishop
QA Contact: Tzach Shefi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-13 15:15 UTC by alisci
Modified: 2022-03-23 22:12 UTC (History)
4 users (show)

Fixed In Version: python-os-brick-2.10.8-2.20220112064935.458bfad.el8ost
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-23 22:12:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 799035 0 None MERGED linuxscsi: Only raise and log multipathd errors when required 2021-12-13 15:24:52 UTC
Red Hat Issue Tracker OSP-11811 0 None None None 2021-12-13 15:20:33 UTC
Red Hat Product Errata RHBA-2022:1001 0 None None None 2022-03-23 22:12:53 UTC

Description alisci 2021-12-13 15:15:15 UTC
Description of problem:

Logging and then ignoring multipathd errors when it isn't enforced is
confusing to operators investigating attach or detach issues.

this has been already addressed in upstream by https://review.opendev.org/c/openstack/os-brick/+/799035


Version-Release number of selected component (if applicable):


How reproducible:

when multipathd is not used, the error:

ERROR os_brick.initiator.linuxscsi [req-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx - xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx] multipathd is not running: exit code 1: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.

is shown on nova-compute logs during detach volumes and on cinder-volume logs during volume creation


Actual results:
the following error is show:
ERROR os_brick.initiator.linuxscsi [..] multipathd is not running: exit code 1: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.


Expected results:
the error log should be shown only if exception is raised


Additional info:

Comment 1 Alan Bishop 2021-12-13 15:24:53 UTC
Upstream backports are under way.

Comment 2 Alan Bishop 2022-01-10 17:54:39 UTC
Pulling in the upstream patch via RDO, https://review.rdoproject.org/r/c/rdoinfo/+/37957

Comment 6 Tzach Shefi 2022-02-28 10:20:28 UTC
Verified on:
python3-os-brick-2.10.8-2.20220112064935.458bfad.el8ost.noarch

On a netapp iSCSI backed Cinder deployment, without multipath installed.

I had done all these operation:
Booted an instance
created a volume from an image
attached the volume to the instance
Detached the volume from the instance
Delete the volume, create a new empty volume,
create a new volume from an image
attach/detach the last volume it from the instance. 

During all of these operations I didn't spot a single multi path error similar to the ones described on the initial bz comment.
Neither on compute node nor on Cinder volumes log. 

I'd say we're good to verify.

Comment 11 errata-xmlrpc 2022-03-23 22:12:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 16.2.2), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1001


Note You need to log in before you can comment on or make changes to this bug.