Bug 2032518 - Bonding Rendered Templates have incorrect indentation
Summary: Bonding Rendered Templates have incorrect indentation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates
Version: 16.1 (Train)
Hardware: All
OS: All
medium
medium
Target Milestone: z9
: 16.1 (Train on RHEL 8.2)
Assignee: OSP Team
QA Contact: Joe H. Rahme
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-14 15:45 UTC by Shailesh Chhabdiya
Modified: 2023-09-18 04:29 UTC (History)
7 users (show)

Fixed In Version: openstack-tripleo-heat-templates-11.3.2-1.20220601143346.29a02c1.el8ost
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-07 20:29:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 826586 0 None MERGED Fix indentation issue with 2-bonds-vlans config 2022-07-21 13:52:21 UTC
Red Hat Issue Tracker OSP-11835 0 None None None 2021-12-14 15:46:25 UTC
Red Hat Product Errata RHSA-2022:8796 0 None None None 2022-12-07 20:29:37 UTC

Description Shailesh Chhabdiya 2021-12-14 15:45:00 UTC
Description of problem:
Nic Config templates created post rendering have incorrect indentation

Version-Release number of selected component (if applicable):
RHOSP16.1/16.2

How reproducible:
Everytime

Steps to Reproduce:
Follow steps 

https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.1/html/advanced_overcloud_customization/custom-network-interface-templates#rendering-default-network-interface-templates-for-customization

Actual results:
Indentation is incorrect 

Expected results:
Indentation should be correct

Additional info:

Comment 1 Shailesh Chhabdiya 2021-12-14 15:49:24 UTC
Hello Team,

Everytime a templates are created using rendering functionality it gives incorrect indentation

Here is one such example

$ cd /usr/share/openstack-tripleo-heat-templates
$ ./tools/process-templates.py -o ~/openstack-tripleo-heat-templates-rendered

/home/stack/openstack-tripleo-heat-templates-rendered/network/config/2-linux-bonds-vlans/controller.yaml

              - type: ovs_bridge
                name: bridge_name
                dns_servers:
                  get_param: DnsServers
                members:
                - type: linux_bond
                  name: bond-data
                  mtu:
                    get_attr: [MinViableMtuBondData, value]
                  bonding_options:
                    get_param: BondInterfaceOvsOptions
                  members:
                  - type: interface
                    name: nic4
                    mtu:
                      get_attr: [MinViableMtuBondData, value]
                    primary: true
                  - type: interface
                    name: nic5
                    mtu:
                      get_attr: [MinViableMtuBondData, value]
              - type: vlan                                                   <<<----------- Should be under member section of ovs_bridge
                device: bond-data
                mtu:
                  get_param: TenantMtu
                vlan_id:
                  get_param: TenantNetworkVlanID
                addresses:
                - ip_netmask:
                    get_param: TenantIpSubnet
                routes:
                  list_concat_unique:
                    - get_param: TenantInterfaceRoutes


This causes the deployment failure always as vlans are to created over ovs-bridge and not under it.

Need to fix this so that rendering provided right set of templates.

Comment 4 Brendan Shephard 2021-12-15 10:27:59 UTC
Hi,

Not sure which DFG should own this, but is this the change you're looking for:
https://review.opendev.org/c/openstack/tripleo-heat-templates/+/821817

Are you able to test that and let me know if that works in your scenario?

Comment 5 Shailesh Chhabdiya 2021-12-20 03:27:54 UTC
Hello Brendan,

Thanks for sharing the details.

I will try it out and get back to you.

Looking at the changes this should definitely work.

Comment 18 errata-xmlrpc 2022-12-07 20:29:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenStack 16.1.9 (openstack-tripleo-heat-templates) security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8796

Comment 19 Red Hat Bugzilla 2023-09-18 04:29:19 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days


Note You need to log in before you can comment on or make changes to this bug.