Bug 203286 - Review Request: sjasm - A z80 cross assembler
Review Request: sjasm - A z80 cross assembler
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Hans de Goede
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2006-08-20 13:04 EDT by Ian Chapman
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-08-20 19:32:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Ian Chapman 2006-08-20 13:04:23 EDT
Spec URL: http://dribble.org.uk/reviews/sjasm.spec
SRPM URL: http://dribble.org.uk/reviews/sjasm-0.39-0.3.g1.src.rpm
SjASM is a two pass macro Z80 cross assembler
Comment 1 Hans de Goede 2006-08-20 13:27:09 EDT
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok (but license file not included)
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on FC-5 i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no .desktop file required


Comment 2 Ian Chapman 2006-08-20 19:23:06 EDT
Thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.