Bug 203286 - Review Request: sjasm - A z80 cross assembler
Summary: Review Request: sjasm - A z80 cross assembler
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-08-20 17:04 UTC by Ian Chapman
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-08-20 23:32:03 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ian Chapman 2006-08-20 17:04:23 UTC
Spec URL: http://dribble.org.uk/reviews/sjasm.spec
SRPM URL: http://dribble.org.uk/reviews/sjasm-0.39-0.3.g1.src.rpm
Description: 
SjASM is a two pass macro Z80 cross assembler

Comment 1 Hans de Goede 2006-08-20 17:27:09 UTC
MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok (but license file not included)
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on FC-5 i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no .desktop file required

Approved!



Comment 2 Ian Chapman 2006-08-20 23:23:06 UTC
Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.