Bug 2033111 - IBM VPC operator library bump removed global CLI args
Summary: IBM VPC operator library bump removed global CLI args
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 4.10
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.10.0
Assignee: Jonathan Dobson
QA Contact: Chao Yang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-15 23:55 UTC by Jonathan Dobson
Modified: 2022-03-10 16:34 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:34:06 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-storage-operator pull 250 0 None open Bug 2033111: IBM VPC operator library bump removed global CLI args 2021-12-21 19:17:21 UTC
Github openshift ibm-vpc-block-csi-driver-operator pull 11 0 None open Bug 2033111: IBM VPC operator library bump removed global CLI args 2021-12-21 19:13:35 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:34:18 UTC

Description Jonathan Dobson 2021-12-15 23:55:13 UTC
The library bump in this PR somehow had a side effect:
https://github.com/openshift/ibm-vpc-block-csi-driver-operator/pull/9


Relevant git history:

[jon@dagobah ibm-vpc-block-csi-driver-operator]$ git log | head -24
commit 872287887f66e095fafcd0ac27ebefe5a0653726
Merge: a67fed2 6896c6b
Author: OpenShift Merge Robot <openshift-merge-robot.github.com>
Date:   Wed Dec 15 09:33:13 2021 +0100

    Merge pull request #9 from dobsonj/bump-libs-4.10
    
    Bump library-go for OCP 4.10 release

commit 6896c6ba6e21afd096946d2a0481fb613293bb5a
Author: Jonathan Dobson <jdobson>
Date:   Tue Dec 14 11:48:45 2021 -0700

    Bump library-go for OCP 4.10 release

commit a67fed227bbc28d4c02c3ea0e64598d35f13f9fd
Merge: a115a3a 4c41a16
Author: OpenShift Merge Robot <openshift-merge-robot.github.com>
Date:   Thu Dec 9 01:08:15 2021 +0000

    Merge pull request #8 from RomanBednar/master
    
    Bug 2028484: CSI driver's livenessprobe does not respect operator's loglevel


Build the operator and run it, using 872287887f66e095fafcd0ac27ebefe5a0653726:

[jon@dagobah ibm-vpc-block-csi-driver-operator]$ make
fatal: No names found, cannot describe anything.
go build -mod=vendor -trimpath -ldflags "-X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.versionFromGit="v0.0.0-unknown" -X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.commitFromGit="8722878" -X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.gitTreeState="clean" -X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.buildDate="2021-12-15T23:34:25Z" " github.com/IBM/ibm-vpc-block-csi-driver-operator/cmd/ibm-vpc-block-csi-driver-operator
[jon@dagobah ibm-vpc-block-csi-driver-operator]$ ./ibm-vpc-block-csi-driver-operator start -h
Start the IBM VPC Block CSI Driver Operator

Usage:
  ibm-vpc-block-csi-driver-operator start [flags]

Flags:
      --config string                    Location of the master configuration file to run from.
  -h, --help                             help for start
      --kubeconfig string                Location of the master configuration file to run from.
      --listen string                    The ip:port to serve on.
      --namespace string                 Namespace where the controller is running. Auto-detected if run in cluster.
      --terminate-on-files stringArray   A list of files. If one of them changes, the process will terminate.
[jon@dagobah ibm-vpc-block-csi-driver-operator]$ 


Then build the commit immediately before the library bump and run it again:

[jon@dagobah ibm-vpc-block-csi-driver-operator]$ git checkout a67fed227bbc28d4c02c3ea0e64598d35f13f9fd
Previous HEAD position was 8722878 Merge pull request #9 from dobsonj/bump-libs-4.10
HEAD is now at a67fed2 Merge pull request #8 from RomanBednar/master
[jon@dagobah ibm-vpc-block-csi-driver-operator]$ make
fatal: No names found, cannot describe anything.
go build -mod=vendor -trimpath -ldflags "-X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.versionFromGit="v0.0.0-unknown" -X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.commitFromGit="a67fed2" -X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.gitTreeState="clean" -X github.com/IBM/ibm-vpc-block-csi-driver-operator/pkg/version.buildDate="2021-12-15T23:36:02Z" " github.com/IBM/ibm-vpc-block-csi-driver-operator/cmd/ibm-vpc-block-csi-driver-operator
[jon@dagobah ibm-vpc-block-csi-driver-operator]$ ./ibm-vpc-block-csi-driver-operator start -h
Start the IBM VPC Block CSI Driver Operator

Usage:
  ibm-vpc-block-csi-driver-operator start [flags]

Flags:
      --config string                    Location of the master configuration file to run from.
  -h, --help                             help for start
      --kubeconfig string                Location of the master configuration file to run from.   
      --listen string                    The ip:port to serve on.
      --namespace string                 Namespace where the controller is running. Auto-detected if run in cluster.
      --terminate-on-files stringArray   A list of files. If one of them changes, the process will terminate.

Global Flags:
      --add-dir-header                   If true, adds the file directory to the header of the log messages
      --alsologtostderr                  log to standard error as well as files
      --log-backtrace-at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log-dir string                   If non-empty, write log files in this directory
      --log-file string                  If non-empty, use this log file
      --log-file-max-size uint           Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --log-flush-frequency duration     Maximum number of seconds between log flushes (default 5s)
      --logtostderr                      log to standard error instead of files (default true)
      --one-output                       If true, only write logs to their native severity level (vs also writing to each lower severity level)
      --skip-headers                     If true, avoid header prefixes in the log messages
      --skip-log-headers                 If true, avoid headers when opening log files
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging


The whole set of Global Flags are now unusable after the library bump.
This caused deployment of the operator to start failing, which prevents install from finishing on ibmcloud.

This PR removes the -v argument to unblock installs:
https://github.com/openshift/cluster-storage-operator/pull/246

But we need to understand why the arguments were affected by the library bump.

Comment 4 Chao Yang 2022-01-05 09:48:59 UTC
oc -n openshift-cluster-csi-drivers exec pod/ibm-vpc-block-csi-driver-operator-5bfd7d58b8-9dgpk -- ps -aux
USER         PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
1000180+       1  0.4  0.5 1517664 88728 ?       Ssl  06:14   0:18 /usr/bin/ibm-vpc-block-csi-driver-operator start -v=2
1000180+      24  0.0  0.0  47588  3460 ?        Rs   07:26   0:00 ps -aux


4.10.0-0.nightly-2021-12-23-153012

Comment 7 errata-xmlrpc 2022-03-10 16:34:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.