Bug 2033810 - 'go vet' fails with Go 1.17: misuse of unbuffered os.Signal channel as argument to signal.Notify
Summary: 'go vet' fails with Go 1.17: misuse of unbuffered os.Signal channel as argume...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Test Framework
Version: 4.10
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: W. Trevor King
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-17 22:26 UTC by W. Trevor King
Modified: 2022-03-07 19:25 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-07 19:25:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift origin pull 26715 0 None Merged Bug 2033810: pkg: Buffer signals for abortCh 2022-03-07 19:23:45 UTC

Description W. Trevor King 2021-12-17 22:26:14 UTC
The required verify presubmit is on the floor, like [1]:

INFO[2021-12-17T19:07:56Z] Tagging openshift/release:rhel-8-release-golang-1.17-openshift-4.10 into pipeline:root. 
...
go vet  ./...
# github.com/openshift/origin/pkg/monitor
pkg/monitor/cmd.go:39:2: misuse of unbuffered os.Signal channel as argument to signal.Notify
# github.com/openshift/origin/pkg/test/ginkgo
pkg/test/ginkgo/cmd_runsuite.go:222:2: misuse of unbuffered os.Signal channel as argument to signal.Notify

Previous success like [2]:

INFO[2021-12-17T17:27:30Z] Tagging openshift/release:rhel-8-release-golang-1.16-openshift-4.8 into pipeline:root. 

Looks like there's some context in [3].

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26712/pull-ci-openshift-origin-master-verify/1471919425958449152
[2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26708/pull-ci-openshift-origin-master-verify/1471894801522626560
[3]: https://github.com/golang/go/issues/45604

Comment 2 Devan Goodwin 2022-03-07 18:33:22 UTC
Trevor does this look ok to close now?

Comment 3 W. Trevor King 2022-03-07 19:25:50 UTC
Ah, yup, verify presubmit passed on [1], so we knew when this landed that the issue was fixed.

[1]: https://github.com/openshift/origin/pull/26715


Note You need to log in before you can comment on or make changes to this bug.