The required verify presubmit is on the floor, like [1]: INFO[2021-12-17T19:07:56Z] Tagging openshift/release:rhel-8-release-golang-1.17-openshift-4.10 into pipeline:root. ... go vet ./... # github.com/openshift/origin/pkg/monitor pkg/monitor/cmd.go:39:2: misuse of unbuffered os.Signal channel as argument to signal.Notify # github.com/openshift/origin/pkg/test/ginkgo pkg/test/ginkgo/cmd_runsuite.go:222:2: misuse of unbuffered os.Signal channel as argument to signal.Notify Previous success like [2]: INFO[2021-12-17T17:27:30Z] Tagging openshift/release:rhel-8-release-golang-1.16-openshift-4.8 into pipeline:root. Looks like there's some context in [3]. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26712/pull-ci-openshift-origin-master-verify/1471919425958449152 [2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26708/pull-ci-openshift-origin-master-verify/1471894801522626560 [3]: https://github.com/golang/go/issues/45604
Trevor does this look ok to close now?
Ah, yup, verify presubmit passed on [1], so we knew when this landed that the issue was fixed. [1]: https://github.com/openshift/origin/pull/26715