Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2034307

Summary:	Allow to set smfs/dmfs modes for mellanox nic in os-net-config
Product:	Red Hat OpenStack	Reporter:	Jacob Ansari <jansari>
Component:	os-net-config	Assignee:	Haresh Khandelwal <hakhande>
Status:	CLOSED ERRATA	QA Contact:	Miguel Angel Nieto <mnietoji>
Severity:	high	Docs Contact:
Priority:	high
Version:	16.2 (Train)	CC:	bfournie, broose, coldford, dsneddon, guilherme.giacon, hakhande, hbrock, jamsmith, jansari, jfargen, jimm, john.choo, jslagle, majd, marjones, mburns, mgeary, mleitner, moshele, mtomaska, nnarang, rvaradar, sbaker, spower, supadhya, tvignaud
Target Milestone:	z2	Keywords:	Bugfix, Triaged
Target Release:	16.2 (Train on RHEL 8.4)
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	os-net-config-11.5.1-2.20211207004923.el8ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-23 22:12:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jacob Ansari 2021-12-20 16:09:33 UTC

Description of problem:
Allow to set smfs/dmfs modes for mellanox nic in os-net-config .

~~~
devlink dev param set pci/<pci-address> flow_steering_mode value smfs cmode runtime
devlink dev eswitch set pci/<pci-address> mode switchdev
~~~
or this:
~~~
devlink dev param set pci/<pci-address> flow_steering_mode value dmfs cmode runtime
devlink dev eswitch set pci/<pci-address> mode switchdev
~~~

(above is lifted from BZ 1882480 )


As mentioned in case asked in case 03106576 : 
"In troubleshooting this feature with RH and Nvidia engineering team, the customer has had to change from SMFS to DMFS steering mode. This change was accomplished manually, but the customer requires a way to override this mode and update it during deployments so the best steering mode may be utilized."

In the previous BZ on this matter (  https://bugzilla.redhat.com/show_bug.cgi?id=1882480#c6 ), setting to smfs if switchdev and dmfs otherwise was decided upon . However, this does not address customer's actual need to selectively override SMFS or DMFS defaults for optimum performance .


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Steve Baker 2022-01-04 21:01:07 UTC

Assigning to networking for dsneddon triage

Comment 9 Marcelo Ricardo Leitner 2022-01-20 13:37:40 UTC

From Ariel:
https://review.opendev.org/c/openstack/os-net-config/+/824971

Comment 22 Miguel Angel Nieto 2022-03-09 08:24:35 UTC

Verified in RHOS-16.2-RHEL-8-20220301.n.3

Without configuring steering mode in templates (default behaviour)
lspci | grep Mella | grep -v Virtual
04:00.0 Ethernet controller: Mellanox Technologies MT27800 Family [ConnectX-5]
04:00.1 Ethernet controller: Mellanox Technologies MT27800 Family [ConnectX-5]

devlink dev param show pci/0000:04:00.0 name flow_steering_mode
pci/0000:04:00.0:
  name flow_steering_mode type driver-specific
    values:
      cmode runtime value smfs
devlink dev param show pci/0000:04:00.1 name flow_steering_mode
pci/0000:04:00.1:
  name flow_steering_mode type driver-specific
    values:
      cmode runtime value smfs

devlink dev eswitch show pci/0000:04:00.1
pci/0000:04:00.1: mode switchdev inline-mode none encap-mode basic
devlink dev eswitch show pci/0000:04:00.0
pci/0000:04:00.0: mode switchdev inline-mode none encap-mode basic

Configuring in steering_mode in templates in the following way:
              - type: ovs_bridge
                name: br-link0
                mtu: 9000
                use_dhcp: false
                members:
                - type: linux_bond
                  name: mx-bond
                  mtu: 9000
                  bonding_options: "mode=active-backup"
                  members:
                  - type: sriov_pf
                    name: nic11
                    numvfs: 10
                    primary: true
                    promisc: true
                    use_dhcp: false
                    defroute: false
                    link_mode: switchdev
                    steering_mode: dmfs

                  - type: sriov_pf
                    name: nic12
                    numvfs: 10
                    promisc: true
                    use_dhcp: false
                    defroute: false
                    link_mode: switchdev
                    steering_mode: dmfs


lspci | grep Mella | grep -v Virtual
04:00.0 Ethernet controller: Mellanox Technologies MT27800 Family [ConnectX-5]
04:00.1 Ethernet controller: Mellanox Technologies MT27800 Family [ConnectX-5]

devlink dev param show pci/0000:04:00.0 name flow_steering_mode
pci/0000:04:00.0:
  name flow_steering_mode type driver-specific
    values:
      cmode runtime value dmfs
devlink dev param show pci/0000:04:00.1 name flow_steering_mode
pci/0000:04:00.1:
  name flow_steering_mode type driver-specific
    values:
      cmode runtime value dmfs

sudo devlink dev eswitch show pci/0000:04:00.1
pci/0000:04:00.1: mode switchdev inline-mode none encap-mode basic
sudo devlink dev eswitch show pci/0000:04:00.0
pci/0000:04:00.0: mode switchdev inline-mode none encap-mode basic

Comment 30 errata-xmlrpc 2022-03-23 22:12:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 16.2.2), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1001

Comment 31 Red Hat Bugzilla 2023-09-15 01:18:18 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days