RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2034497 - compiler-rt: Use _thread_db_sizeof_pthread in ThreadDescriptorSize
Summary: compiler-rt: Use _thread_db_sizeof_pthread in ThreadDescriptorSize
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: compiler-rt
Version: 9.0
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Tom Stellard
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-21 06:46 UTC by Florian Weimer
Modified: 2023-06-20 11:49 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 2034494
Environment:
Last Closed: 2023-06-20 11:49:34 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github llvm llvm-project issues 52989 0 None open [libsanitizer] Use _thread_db_sizeof_pthread in ThreadDescriptorSize 2022-01-05 06:03:08 UTC
Red Hat Issue Tracker RHELPLAN-106307 0 None None None 2021-12-21 06:50:59 UTC

Description Florian Weimer 2021-12-21 06:46:14 UTC
+++ This bug was initially created as a clone of Bug #2034494 +++

LLVM currently hard-codes the size of struct pthread in the sanitizers, in ThreadDescriptorSize in compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp.

Starting with glibc 2.34 and this commit

commit fef400a2f976d1fd6a4639e6980f6c50ee13fbf5
Author: Florian Weimer <fweimer>
Date:   Mon Jun 28 14:33:53 2021 +0200

    nptl: Export libthread_db-used symbols under GLIBC_PRIVATE
    
    This allows distributions to strip debugging information from
    libc.so.6 without impacting the debugging experience.
    
    Reviewed-by: Carlos O'Donell <carlos>

it is possible to determine sizeof (struct pthread) using dl(v)sym, like this:

  const unsigned int *psize = dlvsym(RTLD_DEFAULT, "_thread_db_sizeof_pthread",
                                     "GLIBC_PRIVATE");
  if (psize != nullptr) {
    val = *psize;
    atomic_store_relaxed(&thread_descriptor_size, val);
    return val;
  }

I'm not sure if upstream will take this change, but we should definitely make it downstream, to avoid mysterious sanitizer problems if we need to change struct pthread in glibc.

Comment 1 Florian Weimer 2022-02-04 17:23:09 UTC
Upstream patch review: https://reviews.llvm.org/D119007


Note You need to log in before you can comment on or make changes to this bug.