Bug 2034890 - CVE-2020-8927 / RUSTSEC-2021-0131: Integer overflow in the bundled Brotli C library
Summary: CVE-2020-8927 / RUSTSEC-2021-0131: Integer overflow in the bundled Brotli C l...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: rust-brotli-sys
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Rust SIG
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-22 11:56 UTC by Fabio Valentini
Modified: 2022-08-12 20:48 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-12 20:48:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Fabio Valentini 2021-12-22 11:56:03 UTC
The brotli-sys crate bundles a very old version of the brotli C library, which is susceptible to CVE-2020-8927. There is now also a RustSec advisory for brotli-sys 0.3.2 - RUSTSEC-2021-0131.

The brotli library in Fedora has been updated to a version that does not have this issue long ago:

https://bodhi.fedoraproject.org/updates/FEDORA-2020-c76a35b209
https://bodhi.fedoraproject.org/updates/FEDORA-2020-9336b65f82
https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc9a739f0c

However, the package for the brotli-sys crate bundles brotli 0.6.0, which is very very old (released on April 10, 2017).

CVE entry for brotli:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-8927

RustSec advisory:
https://rustsec.org/advisories/RUSTSEC-2021-0131.html

Upstream issue:
https://github.com/bitemyapp/brotli2-rs/issues/45

There is also no mechanism in this package to build against system libbrotli, which would have prevented such a problem. Maybe optionally building with bindgen against system libbrotli can be made an option?

Comment 1 Ben Cotton 2022-02-08 21:19:34 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 2 Fabio Valentini 2022-08-12 20:48:16 UTC
Since the update to actix-web v4, the package for the brotli-sys crate is unused in Fedora, except as a dependency of rust-brotli2, which is, in turn, no longer depended on by any Fedora package. I will probably retiring both of them, considering that upstream has been pretty dead since 2021, and ignoring requests to update the bundled brotli library. (c.f. https://github.com/bitemyapp/brotli2-rs/issues/45)


Note You need to log in before you can comment on or make changes to this bug.