Description of problem: I would like to suggest that the Fedora firefox package could put its langpacks into a subpackage since they are rather large. This would give the option for users that only need English firefox to uninstall the firefox-langpacks subpackage reducing the diskspace and the size of updates. firefox could pull in firefox-langpacks as a weak dependency so that it would be installed by default, but could be removed if wanted. I think it would also be possible to make the langpacks subpackage noarch? I think we could also support it in the Fedora langpacks metapackages. How do you think of this idea?
Sure, I'm for it. Unfortunately we (Fedora Firefox team) do not have time to work on that but we'll surely take such patches.
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle. Changing version to 36.
Great I have opened https://src.fedoraproject.org/rpms/firefox/pull-request/43
Okay I updated my PR to avoid conflicts with the changelog hunk. Let me know if you have any questions or comments.
I did also ponder if this deserves a Fedora Change? Happy to help out with that if it makes sense.
Sorry for the late reply. How are the langpack rpm files created? Are they generated from the existing firefox-langpacks-XXXX langpack source file? I don't want to change how the package is updated in git as the update process is fast and efficient (we upload only source + langpack file to git and change version number).
If you attach a patch here I'll create a test build in koji.
Thanks - did you see https://src.fedoraproject.org/rpms/firefox/pull-request/43 ? which includes a scratch build
Or you can take the patch from https://src.fedoraproject.org/rpms/firefox/pull-request/43.patch
It might well make sense to announce this as a F37 System Wide Change.
How does it affect recent installations? Is it possible to ship that on F35/F36 too?
Sorry, forgot to respond to this (In reply to Martin Stransky from comment #6) > How are the langpack rpm files created? Are they generated from the existing > firefox-langpacks-XXXX langpack source file? It is using the current Fedora files: there is no change in content (just rpm packaging). > I don't want to change how the package is updated in git as the update > process is fast and efficient (we upload only source + langpack file to git > and change version number). No change is needed as far as i can see
(In reply to Martin Stransky from comment #11) > How does it affect recent installations? Good question > Is it possible to ship that on F35/F36 too? Yes, I think it is possible, but honestly I would suggest to ship it first in F37. I can update the patch to only make the subpackage for F37+ for now. Then later once it looks good we could enable it for F36 and possibly F35. How does that sound? I think it would be good to get it into Rawhide soon.
BTW the deadline for F37 System Wide Changes is tomorrow. So if we wanted to do that it should ideally be submitted today even. I would be happy to write the draft and run it by you, if you like.
(In reply to Jens Petersen from comment #13) > I can update the patch to only make the subpackage for F37+ for now. Done in my latest commit cacf128 now. (Also note I earlier removed the changelog to avoid merge conflicts: let me know if you need one.)
Thanks. Yes, we need it as system wide change for Fedora 37 due to weak dependency used. Also we use the same firefox.spec file for all Fedoras so please keep the current langpacks scenario for Firefox < 37. We commit to rawhide only and then merge to all other branches.
Yes, please do the system wide change request form.
(In reply to Martin Stransky from comment #16) > Thanks. Yes, we need it as system wide change for Fedora 37 due to weak > dependency used. > Also we use the same firefox.spec file for all Fedoras so please keep the > current langpacks scenario for Firefox < 37. > We commit to rawhide only and then merge to all other branches. Yep it is already done in my fork.
Draft Change proposal is https://fedoraproject.org/wiki/Changes/Firefox_Langpacks_Subpackage Do please have a look and feel free to improve it of course.
(In reply to Martin Stransky from comment #16) > Thanks. Yes, we need it as system wide change for Fedora 37 due to weak > dependency used. > Also we use the same firefox.spec file for all Fedoras so please keep the > current langpacks scenario for Firefox < 37. > We commit to rawhide only and then merge to all other branches. Sure - I realised that needs more tweaking - I was mistaken on the status, sorry.
I updated my PR again - maybe I can test it on F36...
F36 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=88801391 (no firefox-langpacks) I am not able to scratch build for F37 (should have firefox-langpacks)
Yes, it fails to build. I need to rebase to 102 anyway so will look at it.