Spec URL: https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03079272-vala-language-server/vala-language-server.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03079272-vala-language-server/vala-language-server-0.48.3-1.fc36.src.rpm Koji Build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=80362832 Description: Provides code intelligence for Vala (and also Genie). Used with an editor and a plugin that supports the Language Server Protocol. Fedora Account System Username: amz ___ This is my 3rd package review request. I'm still looking for a sponsor.
Bumped to newer upstream release v0.48.4 [https://github.com/Prince781/vala-language-server/releases/tag/0.48.4] Spec URL: https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03093369-vala-language-server/vala-language-server.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03093369-vala-language-server/vala-language-server-0.48.4-1.fc36.src.rpm Koji Scratch Build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=80635361 Description: Provides code intelligence for Vala (and also Genie). Used with an editor and a plugin that supports the Language Server Protocol. Fedora Account System Username: amz
Koji Scratch Build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=80636451
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. OK: rpmautospec - Since there is one GPLv3+ source in the package, I recommend adding a comment above the License tag: # The entire source is LGPLv2+, except plugins/gnome-builder/vala_langserv.py, # which is GPLv3+. It is not installed when the “plugins” meson option is # false. Although… is there any reason not to build the plugins? You can add BuildRequires: gnome-builder BuildRequires: python3-devel and set %meson -Dplugins=true and then add %package plugins Summary: Plugins providing integration with Vala Language Server License: GPLv3+ BuildArch: noarch Requires: %{name} = %{version}-%{release} Requires: gnome-builder %description plugins This provides plugins for integration with Vala Language Server. Currently, there is one plugin, for gnome-builder. and, after %meson_install: %py_byte_compile %{python3} %{buildroot}%{_libdir}/gnome-builder/plugins/vala_langserv.py and %files plugins %{_libdir}/gnome-builder/plugins/vala_langserv.plugin %pycached %{_libdir}/gnome-builder/plugins/vala_langserv.py and then change the comment above the main License tag to # The entire source is LGPLv2+, except plugins/gnome-builder/vala_langserv.py, # which is GPLv3+ and is installed in the -plugins subpackage. and perhaps adjust the hint Suggests: gnome-builder to Suggests: %{name}-plugins = %{version}-%{release} - The glob for the man page must not assume .gz compression, and you should use the _mandir macro. Replace %{_datadir}/man/man1/%{name}.1.gz with %{_mandir}/man1/%{name}.1* https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU General Public License v3.0 or later". 24 files have unknown license. Detailed output of licensecheck in /home/reviewer/2035369-vala- language-server/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream provides a test client that can be compiled with the -Dtests=true option to %meson, but it seems to be for interactive testing. It looks like there are no automated tests to run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/Prince781/vala-language-server/archive/0.48.4/vala-language-server-0.48.4.tar.gz : CHECKSUM(SHA256) this package : 9de5d476a3d3b5d4f22f50af6c2417abd44066ab4231cbc00628e9fdab735100 CHECKSUM(SHA256) upstream package : 9de5d476a3d3b5d4f22f50af6c2417abd44066ab4231cbc00628e9fdab735100 Requires -------- vala-language-server (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgee-0.8.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libjson-glib-1.0.so.0(libjson-glib-1.0.so.0)(64bit) libjsonrpc-glib-1.0.so.1()(64bit) libvala libvala-0.54.so.0()(64bit) pkgconfig(gee-0.8) pkgconfig(glib-2.0) pkgconfig(gobject-introspection-1.0) pkgconfig(json-glib-1.0) pkgconfig(jsonrpc-glib-1.0) rtld(GNU_HASH) vala-language-server-debuginfo (rpmlib, GLIBC filtered): vala-language-server-debugsource (rpmlib, GLIBC filtered): Provides -------- vala-language-server: vala-language-server vala-language-server(x86-64) vala-language-server-debuginfo: debuginfo(build-id) vala-language-server-debuginfo vala-language-server-debuginfo(x86-64) vala-language-server-debugsource: vala-language-server-debugsource vala-language-server-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2035369 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: PHP, Perl, SugarActivity, Haskell, C/C++, Python, R, Ocaml, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 vala-language-server-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/vala-language-server-0.48.4-1.fc36.x86_64.debug vala-language-server-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/vala-language-server-0.48.4-1.fc36.x86_64.debug vala-language-server-debuginfo.x86_64: W: no-documentation vala-language-server-debugsource.x86_64: W: no-documentation vala-language-server-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c9/9b9fea7ba3da5f9b16b07e4b94d75ca43bef0c ../../../.build-id/c9/9b9fea7ba3da5f9b16b07e4b94d75ca43bef0c 4 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.6 s
Hi Ben, Thank you for taking the review! The reason why I'm not building the gnome-builder vls plugin is because it is already being built by gnome-builder since version 41, please see the following: - gnome-builder spec which builds the plugin: https://src.fedoraproject.org/rpms/gnome-builder/raw/rawhide/f/gnome-builder.spec - gnome-builder upstream vls plugin: https://gitlab.gnome.org/GNOME/gnome-builder/-/tree/main/src/plugins/vls - vala-language-server upstream commit also disabling plugin by default: https://github.com/Prince781/vala-language-server/commit/4ae7150ad9ee4a5cb9f09fe82834a68cb0150be4 ===== Updated spec to include license comment and %{_mandir} macro. Spec URL: https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03134600-vala-language-server/vala-language-server.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/amz/extras/fedora-rawhide-x86_64/03134600-vala-language-server/vala-language-server-0.48.4-1.fc36.src.rpm Koji scratch rawhide build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=80992861 =====
(In reply to Christopher Crouse from comment #4) > Hi Ben, > > Thank you for taking the review! > > The reason why I'm not building the gnome-builder vls plugin is because it > is already being built by gnome-builder since version 41, please see the > following: That makes perfect sense! I’ll look at your updated submission as soon as I have a chance.
Approved by inspection of the spec file diff: --- ../../srpm-unpacked/vala-language-server.spec 2021-12-30 08:39:55.000000000 -0500 +++ srpm-unpacked/vala-language-server.spec 2022-01-08 11:26:37.000000000 -0500 @@ -2,6 +2,10 @@ Summary: Language server for the Vala programming language Version: 0.48.4 Release: %autorelease + +# The entire source is LGPLv2+, except plugins/gnome-builder/vala_langserv.py, which is GPLv3+. +# It is not installed when the "plugins" meson option is set to false. +# Since GNOME Builder 41, the VLS the plugin has been included. License: LGPLv2+ URL: https://github.com/Prince781/vala-language-server @@ -58,7 +62,7 @@ %{_bindir}/%{name} -%{_datadir}/man/man1/%{name}.1.gz +%{_mandir}/man1/%{name}.1* %changelog Updated rpmlint output: =============================================== rpmlint session starts =============================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 vala-language-server-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/vala-language-server-0.48.4-1.fc36.x86_64.debug vala-language-server-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/vala-language-server-0.48.4-1.fc36.x86_64.debug vala-language-server-debuginfo.x86_64: W: no-documentation vala-language-server-debugsource.x86_64: W: no-documentation vala-language-server-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c9/9b9fea7ba3da5f9b16b07e4b94d75ca43bef0c ../../../.build-id/c9/9b9fea7ba3da5f9b16b07e4b94d75ca43bef0c ================ 4 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.6 s ================
$ fedpkg request-repo vala-language-server 2035369 https://pagure.io/releng/fedora-scm-requests/issue/40989
scm repo was created
FEDORA-2022-c1138abad3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c1138abad3
FEDORA-2022-c1138abad3 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-7a7736c314 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7a7736c314
FEDORA-2022-7a7736c314 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-7a7736c314` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7a7736c314 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-7a7736c314 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.