Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://dcavalca.fedorapeople.org/review/rust-count-zeroes/rust-count-zeroes.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-count-zeroes/rust-count-zeroes-0.2.1-1.fc36.src.rpm Description: Count zeroes on a disk or a file. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=80418129
Taking on this review. === Is the /usr/bin/count-zeroes binary really something you want to deal with shipping? If it is unused and you only need the "library", I recommend to drop it. You can use a simple patch to add "autobins = false" to Cargo.toml, which should make rust2rpm do all the right things to make this a library-only package.
Yeah, for this one I think the binary is useful (e.g. for checking a sparse file or disk image) so it's worth shipping.
If that is the case, then you will need to make sure the License tag of the subpackage that contains this binary is correct. It looks like this crate has no external dependencies, so I don't think you need to do anything, but keep in mind that you need to keep the License tag of the binary package up-to-date if you update this crate in the future, as it might add external dependencies that are not "MIT or ASL 2.0". === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add package to rust-sig with "commit" access - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
Thanks! $ fedpkg request-repo rust-count-zeroes 2035525 https://pagure.io/releng/fedora-scm-requests/issue/41036
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-count-zeroes
FEDORA-2022-0352032bdf has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0352032bdf
FEDORA-2022-0352032bdf has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.