Bug 2035937 - GstPlayer broken with GstPlayerVideoOverlayVideoRenderer in 1.19.2
Summary: GstPlayer broken with GstPlayerVideoOverlayVideoRenderer in 1.19.2
Alias: None
Product: Fedora
Classification: Fedora
Component: gstreamer1-plugins-bad-free
Version: 35
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2021-12-28 17:13 UTC by Scott Talbert
Modified: 2022-01-21 16:20 UTC (History)
4 users (show)

Fixed In Version: gstreamer1-plugins-bad-free-1.19.3-4.fc35
Doc Type: ---
Doc Text:
Clone Of:
Last Closed: 2022-01-21 16:20:49 UTC
Type: Bug

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
freedesktop.org Gitlab gstreamer gstreamer issues 878 0 None closed GstPlayer broken with GstPlayerVideoOverlayVideoRenderer in 1.19.2 2021-12-28 17:13:28 UTC

Description Scott Talbert 2021-12-28 17:13:28 UTC
GstPlayer seems to have broken in 1.19.2 (possibly due to the port to use GstPlay?) when using GstPlayerVideoOverlayVideoRenderer. I noticed the problem with wxMediaCtrl in wxWidgets, but I can reproduce the same problem with the gst-examples/playback/player/gtk example.

Expected Behavior
GstPlayer still uses the overlay window.

Observed Behavior
GstPlayer fails to use the overlay window and produces these errors:

(gtk-play:198757): GLib-GObject-CRITICAL **: 15:47:47.674: g_object_get_property: assertion 'G_IS_OBJECT (object)' failed

** (gtk-play:198757): CRITICAL **: 15:47:47.674: gst_player_video_overlay_video_renderer_create_video_sink: assertion 'GST_IS_VIDEO_OVERLAY (video_overlay)' failed

    Operating System: Fedora 35
    Device: Computer
    **GStreamer Version: 1.19.2
    Command line:

Steps to reproduce the bug
    Roll gst-examples repository back to f8cbae9d (before it was ported to GstPlay).
    Make the below hacky patch to the gtk-play example (to force it to use GstPlayerVideoOverlayVideoRenderer instead of its own renderer).

diff --git a/playback/player/gtk/gtk-play.c b/playback/player/gtk/gtk-play.c
index 786458e..c461f01 100644
--- a/playback/player/gtk/gtk-play.c
+++ b/playback/player/gtk/gtk-play.c
@@ -1425,7 +1425,7 @@ create_ui (GtkPlay * play)
       GTK_WINDOW (play));
   play->renderer = gst_player_gtk_video_renderer_new ();
-  if (play->renderer) {
+  if (0 /*play->renderer*/) {
     play->video_area =
         gst_player_gtk_video_renderer_get_widget (GST_PLAYER_GTK_VIDEO_RENDERER

    Run it, select a video, observe that the video opens its own window (instead of using the overlay) and observe the error messages/warnings.

How reproducible is the bug?

Note, this bug has been fixed upstream and I would like to get the fixes backported to F35.

Comment 1 Fedora Update System 2022-01-10 16:57:29 UTC
FEDORA-2022-f8c35c645e has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f8c35c645e

Comment 2 Fedora Update System 2022-01-11 01:44:56 UTC
FEDORA-2022-f8c35c645e has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-f8c35c645e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f8c35c645e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2022-01-21 16:20:49 UTC
FEDORA-2022-f8c35c645e has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.