Spec URL: https://jjames.fedorapeople.org/ocaml-stdcompat/ocaml-stdcompat.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-stdcompat/ocaml-stdcompat-17-1.fc36.src.rpm Fedora Account System Username: jjames Description: Stdcompat is a compatibility layer allowing programs to use some recent additions to the OCaml standard library while preserving the ability to be compiled on former versions of OCaml. The Stdcompat API is not intended to be stable, but there will be efforts to allow future versions of Stdcompat to be compiled on a large range of versions of OCaml: Stdcompat should compile (at least) on every version of OCaml from 3.08 (inclusive). The module Stdcompat provides some definitions for values and types introduced in recent versions of the standard library. These definitions are just aliases to the matching definition of the standard library if the latter is recent enough. Otherwise, the module Stdcompat provides an alternative implementation.
Package approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "FSF All Permissive License", "[generated file]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License [generated file]", "X11 License [generated file]", "*No copyright* BSD 2-Clause License". 202 files have unknown license. Detailed output of licensecheck in /home/arthur/fedora-review/2036398-ocaml-stdcompat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. Reviewers note: explained in comment [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint (manually) ------------------ ocaml-stdcompat-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/stdcompat/stdcompat.cmxs-17-1.fc36.x86_64.debug ocaml-stdcompat-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/stublibs/dllstdcompat__stubs.so-17-1.fc36.x86_64.debug ocaml-stdcompat-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/ocaml-stdcompat-17-1.fc36.x86_64 ocaml-stdcompat-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/stdcompat/libstdcompat__stubs.a ocaml-stdcompat-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/stdcompat/stdcompat.a ocaml-stdcompat.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/stdcompat/stdcompat.cmxs ocaml-stdcompat.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/stublibs/dllstdcompat__stubs.so ocaml-stdcompat-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/stdcompat/stdcompat.cmxs-17-1.fc36.x86_64.debug ocaml-stdcompat-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/stublibs/dllstdcompat__stubs.so-17-1.fc36.x86_64.debug ocaml-stdcompat-debuginfo.x86_64: W: no-documentation ocaml-stdcompat-debugsource.x86_64: W: no-documentation ocaml-stdcompat-devel.x86_64: W: no-documentation ocaml-stdcompat-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/ocaml-stdcompat-17-1.fc36.x86_64 ocaml-stdcompat-devel.x86_64: E: lto-no-text-in-archive /usr/lib64/ocaml/stdcompat/libstdcompat__stubs.a ocaml-stdcompat-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz ocaml-stdcompat-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz ocaml-stdcompat-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/28/9ef486a228c2b33b60158fed04fb7d6d73cdbf ../../../.build-id/28/9ef486a228c2b33b60158fed04fb7d6d73cdbf ocaml-stdcompat-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/47/46b6dec92c9806ef7a27af8477352e690a5d03 ../../../.build-id/47/46b6dec92c9806ef7a27af8477352e690a5d03 ==== 5 packages and 1 specfiles checked; 9 errors, 9 warnings, 9 badness; has taken 4.3 s =====
Thank you, Arthur. I appreciate the review.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-stdcompat
This package has been built in Rawhide.