Bug 203689 - Remove explicit 'Requires: nagios-plugins' for submodules
Summary: Remove explicit 'Requires: nagios-plugins' for submodules
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: nagios-plugins
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mike McGrath
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-08-23 07:31 UTC by Enrico Scholz
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-30 01:07:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Enrico Scholz 2006-08-23 07:31:49 UTC
Description of problem:

Please remove the explicit

| Requires: nagios-plugins = %version-%release

from most subpackages. Most checks are C programs which do not need the
functionality of the 'nagios-plugins' package. Because this package adds huge
dependencies (perl), it will bloat up NRPE or NCSA based sensor hosts.

When removing the explicit Requires:, you will run into an unowned directories
problem. This can be solved e.g. by a 'nagios-filesystem' package providing the
filesystem structure.


Version-Release number of selected component (if applicable):

nagios-plugins-1.4.3-17.fc5

Comment 1 Mike McGrath 2006-08-25 14:37:51 UTC
I'm debating what to do about this.  Using the nagios-filesystem method seems
like an ugly hack for an issue that will have an affect on only few people
(those running a nagios plugin on a system that doesn' have perl)

Comment 2 Enrico Scholz 2006-08-25 15:06:52 UTC
An "affect ... only few people" statement is one of the stupiest arguments on
this issue.

Most plugins are small C programs which run perfectly without perl. Adding a
bloaty perl dependency without a reason is a packaging bug.

Separate -filesystem packages are a clean solution.

Comment 3 Roy-Magne Mo 2006-08-25 15:12:55 UTC
Why not split the perl modules into it's own subpackage and place it in the
correct place for a perl module. This will be pulled automatically as a part of
resolving the perl dependencies.

It's a cleaner solutions IMHO.

Comment 4 Mike McGrath 2006-08-25 15:13:57 UTC
This 'issue' is made up.  There are only a tiny portion of people out there who
are running machines without perl.  Unless someone can provide me a compelling
reason to do this without calling my arguments stupid this will go to WONTFIX quick.

Comment 5 Mike McGrath 2006-08-25 15:17:54 UTC
I didn't mean to actually close this.

Comment 6 Roy-Magne Mo 2006-08-25 15:20:02 UTC
Because you are not able to see it as a problem from your standpoint, there is
no reason to dismiss a better solution.

nagios-plugins is already an massive amount of packages, and splitting it up
into more logical parts don't hurt.


Comment 7 Mike McGrath 2006-08-25 15:25:19 UTC
If by splitting it up you mean making more packages that only benefit few people
while also making it more difficult to maintain then yeah, I don't see the
problem.  I'm not saying I won't do it but I need more input from people.

Comment 8 Mike McGrath 2006-08-25 15:39:41 UTC
What if I explicitly told rpm that the base nagios-plugins script does not
require perl?  This way when packages get updated I don't have to check to see
if check_breeze is still perl based or that check_dhcp is still a binary.  Also,
rpm does not auto resolve the individual plugins to require utils.pm for some
reason.

Comment 9 Roy-Magne Mo 2006-08-25 15:54:17 UTC
I just looked in to this, the perl module utils.pm is not well structured at
all, it should be named Nagios::Utils or something like that, and the perl
programs should require this - this way this would be handled automatically. It
seems like there are better modules on it's way for a future version. So my
suggestion is to hold this change off until the new modules are included.
Alternatively create a patch that cleans up the perl provides and requires,
since it's kind of messy at the moment. Then again this is probably more of a
upstream bug.

Comment 10 Enrico Scholz 2006-08-25 16:32:53 UTC
you could

1. move utils.pm into own subpackage (e.g. nagios-plugins-perl)
2. use a filter like
   | %global reqfilt sh -c "%{__perl_requires} | sed -e 's!perl(utils)!nagios-plugins-perl!'"
   | %define __perl_requires %{reqfilt}


Comment 11 Axel Thimm 2006-08-25 21:22:29 UTC
Why do all readers of the Fedora Extras list need to get copies of this bug
report? Removing from the Cc.


Comment 12 Mike McGrath 2006-08-30 01:07:10 UTC
Used method from comment #10.  Let me know if I've broken anything.


Note You need to log in before you can comment on or make changes to this bug.