RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2037015 - [RFE] Provide a way for mkksiso to customize existing kernel command line parameters
Summary: [RFE] Provide a way for mkksiso to customize existing kernel command line par...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: lorax
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Brian Lane
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks: 1942219
TreeView+ depends on / blocked
 
Reported: 2022-01-04 16:24 UTC by Jiri Kortus
Modified: 2022-11-15 10:58 UTC (History)
2 users (show)

Fixed In Version: lorax-34.9.19-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:11:08 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-106810 0 None None None 2022-01-04 16:32:51 UTC
Red Hat Issue Tracker RTT-4555 0 None None None 2022-05-23 14:43:15 UTC
Red Hat Issue Tracker RTT-4556 0 None None None 2022-05-23 14:43:19 UTC
Red Hat Product Errata RHBA-2022:8018 0 None None None 2022-11-15 10:11:20 UTC

Description Jiri Kortus 2022-01-04 16:24:42 UTC 
Description of problem:
It would be useful if mkksiso provided a way to modify already existing kernel command line parameters. Namely I found a need for such feature when I wanted to modify an ISO that already contains a kickstart (image-installer image built by osbuild-composer), and such modification resulted in the inst.ks anaconda option being present twice on the kernel command line. Although Anaconda just displays a warning because of that and the kickstart is used properly, this is not a very clean solution.

I can imagine at least two ways this could be solved:
1. Add an option for mkksiso to not require a kickstart (which actually would make sense, although this may sound counterintuitive for mkksiso).
2. Add an option to rewrite the existing command line parameters with arbitrary ones (so that the current ones without the inst.ks option could be passed to mkksiso) and just append the inst.ks option for the kickstart passed to mkksiso in the same way it works at this moment.

Version-Release number of selected component (if applicable):
lorax-34.9.10-1.el9.x86_64

Actual results:
It's not possible to change the existing kernel command line parameters (e. g. remove the existing inst.ks option) when using mkksiso.

Expected results:
It is possible to change the existing kernel command line parameters (e. g. remove the existing inst.ks option) when using mkksiso.
Comment 2 Brian Lane 2022-01-10 23:37:21 UTC 
Hm, I hadn't considered using it again on a produced image :) I assumed you'd just make it again with the new kickstart.

I'll take a look at making it flexible enough that it recognizes that it already has a kickstart on it. It should also be possible to replace existing arguments since they are all space separated. Something like:

mkksiso --set-arg="inst.sshd rd.debug selinux=0" ...
Comment 3 Jiri Kortus 2022-01-11 14:42:07 UTC 
Thanks for having a look, Brian, that sounds good to me! I know it might be a sort of corner-case (I needed that when creating a test in the first place), but my guess is that sooner or later someone else may need this as well when playing with mkksiso and ISOs created with osbuild-composer :).
Comment 5 Brian Lane 2022-05-26 23:12:11 UTC 
Upstream commit - https://github.com/weldr/lorax/pull/1230

I'd prefer to have bug #2088631 first, otherwise backporting this will be a bit more involved.
Comment 6 Brian Lane 2022-06-28 23:17:24 UTC 
https://github.com/weldr/lorax/pull/1244
Comment 11 Jan Stodola 2022-07-22 09:43:05 UTC 
Unfortunately, this enhancement changed the way how mkksiso is used.

mkksiso /PATH/TO/KICKSTART /PATH/TO/ISO /PATH/TO/NEW-ISO

cannot be used any more and --ks is necessary to add when including a kickstart:

mkksiso --ks /PATH/TO/KICKSTART /PATH/TO/ISO /PATH/TO/NEW-ISO


lorax is an Application Compatibility Level 2 package [1], which means that "application interfaces will not change from minor release to minor release and can be relied upon by the application to be stable for the duration of the major release" [2].

I'm moving this bug back to ASSIGNED to address the incompatibility with mkksiso from RHEL-9.0.


[1] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html-single/package_manifest/index#AppStream-repository
[2] https://access.redhat.com/articles/rhel9-abi-compatibility
Comment 13 Brian Lane 2022-07-22 17:26:26 UTC 
I've figured out how to make it work with --ks or with 3 arguments, PR is here - https://github.com/weldr/lorax/pull/1255
Comment 14 Ondřej Budai 2022-08-01 11:06:40 UTC 
@jstodola Can you please have a look, this is blocking some Image Builder tests, so we would highly appreciate if the build can be preverified soon. :-) Thanks!
Comment 17 Jan Stodola 2022-08-09 12:09:26 UTC 
Checked that lorax-34.9.19-1.el9 is in nightly compose RHEL-9.1.0-20220809.0

Moving to VERIFIED
Comment 19 errata-xmlrpc 2022-11-15 10:11:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (lorax bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8018
Note You need to log in before you can comment on or make changes to this bug.