Description of problem: rhv-image-discrepancies tool that is provided from rhv-log-collector-analyzer-1.0.11-1.el8ev.noarch package reports OVF_STORE volumes as problems. The problem appears due to OVFs created in 4.1 and lower will keep disktype=2. ~~~ DESCRIPTION={"Updated":true,"Size":1354752,"Last Updated":"Mon Sep 06 11:30:22 CEST 2021","Storage Domains":[{"uuid":"bdbcae9c-59af-4fa3-859a-5ad30fe9c085"}],"Disk Description":"OVF_STORE"} DISKTYPE=2 ~~~ Version-Release number of selected component (if applicable): ovirt-engine-4.4.9.5-0.1.el8ev.noarch Wed Dec 22 15:29:33 2021 rhv-log-collector-analyzer-1.0.11-1.el8ev.noarch Wed Dec 22 15:37:04 2021 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: rhv-image-discrepancies reports the following in the output: ~~~ Checking storage domain 0b15810c-87d7-49f8-8d89-1ac6488de409 Image 7619bce7-9be0-4ba3-9561-56f7eecd6bf5 has a different attribute capacity on storage(134217728) and on DB(144896) ~~~ Expected results: The rhv-image-discrepancies shouldn't flag OVF_STORE volumes. Additional info:
The problem is the original fix on BZ1989324 uses storage metadata disktype key to find OVF disks. But in case of upgrades from old versions (4.1 and lower), disktype will be set to '2' (==Legacy) instead of OVFS. So the proposed patch adds a second if condition to look into description in case the disktype is legacy.
Note for QE: To reproduce I think the following will do. 1. Deploy 4.1 2. create SD 3. Upgrade to latest 4. Run rhv-image-discrepancies The idea is to have an OVF_STORE volume with disktype=2 (legacy), similar to this: [root@rhvh-1 ~]# dd if=/dev/2f93a595-a602-4bfc-b35e-9e78b89f27b4/metadata bs=8192 count=1 skip=129 CAP=134217728 CTIME=1635458093 DESCRIPTION={"Updated":true,"Size":12800,"Last Updated":"Wed Dec 22 11:52:25 AEST 2021","Storage Domains":[{"uuid":"2f93a595-a602-4bfc-b35e-9e78b89f27b4"}],"Disk Description":"OVF_STORE"} DISKTYPE=2 DOMAIN=2f93a595-a602-4bfc-b35e-9e78b89f27b4 FORMAT=RAW GEN=0 IMAGE=a97751ed-1b59-4073-a69b-ee5d9b203bfc LEGALITY=LEGAL PUUID=00000000-0000-0000-0000-000000000000 TYPE=PREALLOCATED VOLTYPE=LEAF EOF
Verified on rhv-log-collector-analyzer-1.0.13-1.el8ev.noarch OVF_STORE volumes not flagged as problematics
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: RHV Manager (ovirt-engine) [ovirt-4.5.0] security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:4711
Due to QE capacity, we are not going to cover this issue in our automation