Description of problem: In case of a premature 'backup stop' command (backup phase is one of: "INITIALIZING" / "CREATING_SCRATCH_DISKS" / "PREPARING_SCRATCH_DISK" / "STARTING" / "ADDING_BITMAPS" / "WAITING_FOR_BITMAPS"), the event log is slightly confusing - it complains about failure to finalize backup which is not 100% precise. The more correct message would be to state that the backup was finished prematurely and probably change it to warning log level. Version-Release number of selected component (if applicable): 4.4.10 How reproducible: Run full backup and at the same time (pretty much at the beginning of the full backup, before the backup phase changed to "READY") execute 'backup stop' command. Steps to Reproduce: 1. Run full backup. 2. Shortly after that, execute 'backup stop' using the backup UUID of the above full backup. 3. The event log will contain: "Backup XYZ failed to finalize" confusing message. Actual results: Event log contains a confusing error message as if there was an issue with backup finalization, while in fact that was not the case. The engine log and the 'backup stop' command output contain the correct reason. The event log will contain the following: NORMAL Backup ebf0ddbb-ae70-41c2-bce8-c8ce5fcf2db0 for VM VM1 started (User: admin@internal-authz). ERROR Backup ebf0ddbb-ae70-41c2-bce8-c8ce5fcf2db0 for VM VM1 failed to finalize (User: admin@internal-authz). ERROR Backup ebf0ddbb-ae70-41c2-bce8-c8ce5fcf2db0 for VM VM1 failed (User: admin@internal-authz). The log will also contain the premature log message. 2022-01-05 14:03:14,066+02 WARN [org.ovirt.engine.core.bll.storage.backup.StopVmBackupCommand] (default task-29) [3387e48c-5aa5-4308-8fc4-dc711b3088ed] Backup 'ebf0ddbb-ae70-41c2-bce8-c8ce5fcf2db0' is in 'CREATING_SCRATCH_DISKS' phase, premature backup stop was initiated. The 'backup stop' command will end with the following error: ovirtsdk4.Error: Fault reason is "Operation Failed". Fault detail is "[backup 'ebf0ddbb-ae70-41c2-bce8-c8ce5fcf2db0' is in 'creating scratch disks' phase, premature backup stop was initiated.]". HTTP response code is 400. Expected results: 1) The event log should contain a "backup finished prematurely" warning message vs. the current "backup failed to finalize" error message. 2) Something to consider: the final "backup failed" error message might be better updated to something like "backup was canceled/stopped" and also changed to warning log level.
In https://bugzilla.redhat.com/1900552 we are changing the way StopVmBackupCommand stops/finalizes Hybrid backup, which eliminates the above ERROR audit message, and there will be the same message if stop done both before and after READY state: INFO: Backup ${backupId} for VM ${VmName} stopped (User: ${UserName}). This covers fixing audit messages reported here, closing