Bug 2038412 - Import page calls the git file list unnecessarily twice from GitHub/GitLab/Bitbucket
Summary: Import page calls the git file list unnecessarily twice from GitHub/GitLab/Bi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.10.0
Assignee: Abhinandan Das
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-07 20:44 UTC by Christoph Jerolimov
Modified: 2022-03-10 16:37 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:37:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
duplicate-call.png (83.75 KB, image/png)
2022-01-07 20:46 UTC, Christoph Jerolimov
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:37:54 UTC

Description Christoph Jerolimov 2022-01-07 20:44:21 UTC
Description of problem:
Whenever the user changes the git URL on the add page, the browser makes four API calls to GitHub, GitLab, or Bitbucket. One of these calls fetches the same data twice. It looks like the console fetches the git file list twice.

Version-Release number of selected component (if applicable):
4.10

How reproducible:
Always

Steps to Reproduce:
1. Switch to developer perspective
2. Navigate to the add page
3. Open browser network inspector
4. Enter a Git URL or change it

Actual results:
You can see 4 API calls to the git provider. One of them is called twice.

Expected results:
In the current situation I would expect 3 API calls. We should avoid calling the same API twice.

Additional info:
None

Comment 1 Christoph Jerolimov 2022-01-07 20:46:00 UTC
Created attachment 1849508 [details]
duplicate-call.png

Comment 2 Abhinandan Das 2022-01-17 13:45:40 UTC
fixed by https://github.com/openshift/console/pull/10769

Verified on
OpenShift version 4.10.0-0.nightly-2022-01-13-061145
Kubernetes version v1.23.0+50f645e
Channel stable-4.10
Cluster ID 26787444-e326-4bb9-8807-f7f2a362bf27
API server https://api.app-svc-4.10-011707.devcluster.openshift.com:6443

Comment 5 errata-xmlrpc 2022-03-10 16:37:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.