Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://mattia.fedorapeople.org/indi-3rdparty-drivers/indi-3rdparty-drivers.spec SRPM URL: https://mattia.fedorapeople.org/indi-3rdparty-drivers/indi-3rdparty-drivers-1.9.3-3.fc36.src.rpm Description: This is a metapackage for installing all INDI 3rdparty drivers at once. You probably don't want to install everything, but just pick the drivers you need from the appropriate subpackage. Fedora Account System Username: mattia In future this package is meant to replace all INDI drivers currently packaged standalone (at this moment are indi-aagcloudwatcher, indi-apogee, indi-eqmod, indi-gphoto and indi-sx). For this initial attempt, I've enabled only aagcloudwatcher-ng, because the former aagcloudwatcher is no more compatible with libindi 1.9.3 and needs to be replaced ASAP. For the other drivers I'm waiting to hear the opinion of the maintainer of those packages. I'm not sure why, but you probably get rpmlint errors about the driver being linked statically, which isn't true. See the discussion on devel mailing list at https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/EURXRSOAJZOIGJRIFRRPAOXXZTX3FTT7/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=81017597
Just one remark: - The toplevel LICENSE states LGPLv2.1, but all relevant files are GPLv3+: ./indi-aagcloudwatcher-ng/CloudWatcherController_ng.cpp: GNU General Public License v3.0 or later ./indi-aagcloudwatcher-ng/CloudWatcherController_ng.h: GNU General Public License v3.0 or later ./indi-aagcloudwatcher-ng/indi_aagcloudwatcher_ng.cpp: GNU General Public License v3.0 or later ./indi-aagcloudwatcher-ng/indi_aagcloudwatcher_ng.h: GNU General Public License v3.0 or later ./indi-aagcloudwatcher-ng/main.cpp: GNU General Public License v3.0 or later I believe the license should therefore be GPLv3+ and the LICENSE file is incorrect? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [!]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- indi-3rdparty-aagcloudwatcher-ng.x86_64: W: no-manual-page-for-binary aagcloudwatcher_test_ng indi-3rdparty-aagcloudwatcher-ng.x86_64: W: no-manual-page-for-binary indi_aagcloudwatcher_ng indi-3rdparty-drivers.spec: W: invalid-url Source0: indi-3rdparty-drivers-1.9.3.tar.xz Requires -------- indi-3rdparty-drivers (rpmlib, GLIBC filtered): indi-3rdparty-aagcloudwatcher-ng (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libindi libindidriver.so.1()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) indi-3rdparty-aagcloudwatcher-ng-doc (rpmlib, GLIBC filtered): indi-3rdparty-aagcloudwatcher-ng indi-3rdparty-drivers-debugsource (rpmlib, GLIBC filtered): Provides -------- indi-3rdparty-drivers: indi-3rdparty-drivers indi-3rdparty-drivers(x86-64) indi-3rdparty-aagcloudwatcher-ng: indi-3rdparty-aagcloudwatcher-ng indi-3rdparty-aagcloudwatcher-ng(x86-64) indi-aagcloudwatcher indi-3rdparty-aagcloudwatcher-ng-doc: indi-3rdparty-aagcloudwatcher-ng-doc indi-3rdparty-drivers-debugsource: indi-3rdparty-drivers-debugsource indi-3rdparty-drivers-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2038675 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: SugarActivity, R, Java, fonts, Haskell, Python, Ruby, PHP, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
The top level package is a collection of drivers and libraries and is licensed LGPLv2.1. Then there are various drivers, each one with its license. Currently I provided only aagcloudwatcher-ng which is licensed GPLv3+ and I put this license in the tag and in license files of the subpackage.
Oh, right, all good then, approved!
As I'm the maintainer of the old standalone indi-* packages: Feel free to replace all of them! My old packagig is a result of a different repo structure INDI had years ago before moving everything to Github. I thought about exactly the same solution for the driver packages you realized now, but did not find the time to do it. So: Thanks for your work!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/indi-3rdparty-drivers
Package built into Rawhide. Thanks!