Bug 2039429 - Review Request: rust-is_debug - Get build model is debug
Summary: Review Request: rust-is_debug - Get build model is debug
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1990389
TreeView+ depends on / blocked
 
Reported: 2022-01-11 17:43 UTC by Artem
Modified: 2022-01-12 21:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-01-12 18:04:03 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Artem 2022-01-11 17:43:23 UTC
Spec URL: https://atim.fedorapeople.org/rust-is_debug.spec
SRPM URL: https://atim.fedorapeople.org/rust-is_debug-1.0.1-1.fc36.src.rpm

Description:
Get build model is debug.

Fedora Account System Username: atim

Comment 1 Artem 2022-01-11 17:43:26 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=81107610

Comment 2 Zbigniew Jędrzejewski-Szmek 2022-01-12 15:21:53 UTC
+ package name is OK
+ latest version
+ license is acceptable for Fedora (MIT and Apache-2.0)
+ license is specified correctly
+ rust2rpm was used
+ builds and installs OK

rpmlint: nothing interesting

Package is APPROVED.

Comment 3 Zbigniew Jędrzejewski-Szmek 2022-01-12 15:22:27 UTC
One comment: please change the Summary to something that makes sense.

Comment 4 Gwyn Ciesla 2022-01-12 17:46:28 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-is_debug

Comment 5 Artem 2022-01-12 18:04:03 UTC
Thank you. Built for Rawhide.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> One comment: please change the Summary to something that makes sense.

Hope it's a little bit better now https://src.fedoraproject.org/rpms/rust-is_debug/blob/rawhide/f/rust-is_debug.spec#_10

Comment 6 Zbigniew Jędrzejewski-Szmek 2022-01-12 20:57:08 UTC
The new Summary isn't much better ;(  The grammar doesn't make sense, so I can't even parse the meaning.
"Rust crate to check if the build is a debug build"?

Comment 7 Artem 2022-01-12 21:13:21 UTC
We should suggest something better upstream probably. Previously i seen few times during RR that changing summary/description downstream in Fedora is generally discouraged. But i am not against, it sounds really weird. Just need some help and tip here please.


Note You need to log in before you can comment on or make changes to this bug.