RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2039759 - nvme-fabrics has device_t
Summary: nvme-fabrics has device_t
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: selinux-policy
Version: 9.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: 9.0
Assignee: Zdenek Pytela
QA Contact: Milos Malik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-12 11:49 UTC by Jiri Jaburek
Modified: 2023-07-18 07:07 UTC (History)
4 users (show)

Fixed In Version: selinux-policy-34.1.23-1.el9
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-17 15:50:10 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-107575 0 None None None 2022-01-12 11:55:51 UTC
Red Hat Product Errata RHBA-2022:3918 0 None None None 2022-05-17 15:50:18 UTC

Description Jiri Jaburek 2022-01-12 11:49:04 UTC 
Description of problem:

On x86_64 (at least):

# modprobe nvme-fabrics

# ls -Z /dev/nvme-fabrics 
system_u:object_r:device_t:s0 /dev/nvme-fabrics


Version-Release number of selected component (if applicable):
RHEL-9.0.0-20220108.3
selinux-policy-34.1.20-1.el9.noarch
Comment 1 Zdenek Pytela 2022-01-24 15:22:05 UTC 
Ondrej,

Is fixed_disk_device_t the proper type for /dev/nvme-fabrics device?
Also supposing it will be a char device.
I managed to locate it to drivers/nvme/host like here

fabrics:c
1120 static struct miscdevice nvmf_misc = {
1121         .minor          = MISC_DYNAMIC_MINOR,
1122         .name           = "nvme-fabrics",
1123         .fops           = &nvmf_dev_fops,
1124 };
1125

Refer also to our previous discussion in
https://bugzilla.redhat.com/show_bug.cgi?id=2027994
Comment 2 Ondrej Mosnacek 2022-01-28 16:59:54 UTC 
(Sorry for late reply - I thought I had already replied, but the needinfo nag from BZ proved me wrong :)

What I said in https://bugzilla.redhat.com/show_bug.cgi?id=2027994#c3 still applies - I'd prefer to see fixed_disk_device_t used only for block devices (that are used as storage of some kind) and have something like nvme_device_t for the control NVME char devices. That said, I understand that it would be non-trivial to refactor this in the policy, so I'm fine with re-using fixed_disk_device_t here (for now).

And yes, it looks like this will always be a char device.
Comment 3 Zdenek Pytela 2022-01-28 17:09:11 UTC 
Thank you, adding this note to the todo-refactor-list.

I've just submitted a Fedora draft PR to address the issue:
https://github.com/fedora-selinux/selinux-policy/pull/1035
Comment 4 Zdenek Pytela 2022-01-31 15:18:28 UTC 
To backport:
commit a1703c8636c686a30736446a5047abce75e33d11 (HEAD -> rawhide, upstream/rawhide)
Author: Zdenek Pytela <zpytela>
Date:   Fri Jan 28 17:59:01 2022 +0100

    Label /dev/nvme-fabrics with fixed_disk_device_t
Comment 12 errata-xmlrpc 2022-05-17 15:50:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: selinux-policy), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3918
Note You need to log in before you can comment on or make changes to this bug.