RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2040555 - Pinning iothread to not allowed cpuset fails but vm xml got updated unexpectedly
Summary: Pinning iothread to not allowed cpuset fails but vm xml got updated unexpectedly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: libvirt
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Luyao Huang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-14 04:59 UTC by Fangge Jin
Modified: 2022-11-15 10:36 UTC (History)
7 users (show)

Fixed In Version: libvirt-8.1.0-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:03:03 UTC
Type: Bug
Target Upstream Version: 8.1.0
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker LIBVIRTAT-12950 0 None None None 2022-07-22 09:06:59 UTC
Red Hat Issue Tracker RHELPLAN-108155 0 None None None 2022-01-14 05:04:43 UTC
Red Hat Product Errata RHSA-2022:8003 0 None None None 2022-11-15 10:03:22 UTC

Description Fangge Jin 2022-01-14 04:59:50 UTC
Description of problem:
Pinning iothread to not allowed cpuset returns success unexpectedly

Version-Release number of selected component:
libvirt-7.10.0-1.el9.x86_64 or libvirt-8.0.0-0rc1.1.el9.x86_64
kernel-5.14.0-34.el9.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Start a vm

2. Set allowed cpuset on host:
# echo "0,2,3,4,6,8" > /sys/fs/cgroup/machine.slice/cpuset.cpus

3. Add iothread and set iothreadpin
# virsh iothreadadd vm1 3

# virsh iothreadpin vm1 3 9-19
error: cannot set CPU affinity on process 13904: Invalid argument

4. Check vm xml
# virsh dumpxml vm1|grep iothread
  <iothreads>1</iothreads>
  <iothreadids>
    <iothread id='3'/>
  </iothreadids>
    <iothreadpin iothread='3' cpuset='9-19'/>

5. Save and restore vm
# virsh managedsave vm1

Domain 'vm1' state saved by libvirt

6. # virsh start vm1
error: Failed to start domain 'vm1'
error: cannot set CPU affinity on process 15136: Invalid argument

Actual results:
Vm xml is updated when iothreadpin fails, and vm can't be restored after saving

Expected results:
Vm xml should not be updated when iothreadpin fails

Comment 1 Peter Krempa 2022-01-18 08:59:57 UTC
The code indeed updates the internal definition before setting the pinning on the process.

Comment 2 Peter Krempa 2022-01-18 13:20:07 UTC
Fixed upstream:

commit ce20fe5c2abd8b5bf2064452a7fc9ca54eecaf1f
Author: Peter Krempa <pkrempa>
Date:   Tue Jan 18 10:08:03 2022 +0100

    qemuDomainPinIOThread: Update live definition after process pinning
    
    Otherwise we'll keep using the new pinning value even if it can't be
    applied to the thread.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2040555
    Signed-off-by: Peter Krempa <pkrempa>
    Reviewed-by: Ján Tomko <jtomko>
    Reviewed-by: Pavel Hrdina <phrdina>

v8.0.0-64-gce20fe5c2a

Comment 5 Luyao Huang 2022-04-15 07:52:42 UTC
Verify this bug with libvirt-8.2.0-1.el9.x86_64:

1. Start a vm
# virsh list --all
 Id   Name   State
----------------------
 3    vm1    running

2. Set allowed cpuset on host:
# echo "0-3" > /sys/fs/cgroup/machine.slice/cpuset.cpus

3. Add iothread and set iothreadpin
# virsh iothreadadd vm1 3

# virsh iothreadpin vm1 3 4-7
error: cannot set CPU affinity on process 171179: Invalid argument

4. Check vm xml
# virsh dumpxml vm1|grep iothread
  <iothreads>1</iothreads>
  <iothreadids>
    <iothread id='3'/>
  </iothreadids>

5. Save and restore vm
# virsh managedsave vm1

Domain 'vm1' state saved by libvirt

# virsh start vm1
Domain 'vm1' started

6. check vm xml
# virsh dumpxml vm1 |grep iothread
  <iothreads>1</iothreads>
  <iothreadids>
    <iothread id='3'/>
  </iothreadids>

Comment 7 errata-xmlrpc 2022-11-15 10:03:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8003


Note You need to log in before you can comment on or make changes to this bug.