Bug 2040974 - PHP 8 compatibility problems
Summary: PHP 8 compatibility problems
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: phpldapadmin
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dmitry Butskoy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-14 23:49 UTC by Patrick Monnerat
Modified: 2022-01-24 00:46 UTC (History)
1 user (show)

Fixed In Version: phpldapadmin-1.2.6.3-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-01-24 00:46:12 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
1st patch (1011 bytes, application/mbox)
2022-01-14 23:49 UTC, Patrick Monnerat 		no flags Details
2nd patch (9.24 KB, patch)
2022-01-14 23:50 UTC, Patrick Monnerat 		no flags Details | Diff
3rd patch (6.84 KB, patch)
2022-01-14 23:51 UTC, Patrick Monnerat 		no flags Details | Diff
4th patch (1.38 KB, patch)
2022-01-15 10:42 UTC, Patrick Monnerat 		no flags Details | Diff
View All

Description Patrick Monnerat 2022-01-14 23:49:56 UTC 
Created attachment 1850874 [details]
1st patch

Created attachment 1850874 [details]
1st patch

Description of problem:
phpldapadmin does not work at all with PHP >= 8


Version-Release number of selected component (if applicable):
1.2.6.2-3

How reproducible:
Always

Steps to Reproduce:
1. Install
2. Configure
3. Try to run from a browser.

Actual results:
Variouss warnings and error messages.

Expected results:
Working

Additional info:
The Fedora 35 version 1.2.6.2-3 fails because PHP version is >= 8.
I made it work and posted a PR upstream but as they are not very reactive, I leave these 4 patches here in hope you will apply them quicker. Thanks.
Comment 1 Patrick Monnerat 2022-01-14 23:50:53 UTC 
Created attachment 1850875 [details]
2nd patch
Comment 2 Patrick Monnerat 2022-01-14 23:51:30 UTC 
Created attachment 1850876 [details]
3rd patch
Comment 3 Dmitry Butskoy 2022-01-15 00:23:09 UTC 
Maybe give upstream a bit more time (at least a week, as per Fedora policies :) )?

Anyway, Would you like to co-maintain?
Comment 4 Patrick Monnerat 2022-01-15 06:51:37 UTC 

> Maybe give upstream a bit more time (at least a week, as per Fedora policies :) )?

Sure! I just wanted to pull your attention on it: this is not the first time I submit patches to this project and I know they have a very high "latency", if some.

> Anyway, Would you like to co-maintain?

No thanks! I'm already quite busy on some other projects and patched this because I need it. Sorry!
Comment 5 Patrick Monnerat 2022-01-15 10:42:37 UTC 
Created attachment 1850947 [details]
4th patch
Comment 6 Patrick Monnerat 2022-01-15 10:46:55 UTC 
Link to upstream PR: https://github.com/leenooks/phpLDAPadmin/pull/149
Comment 7 Fedora Update System 2022-01-15 23:28:28 UTC 
FEDORA-2022-ec7eb3a63a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ec7eb3a63a
Comment 8 Fedora Update System 2022-01-16 01:52:49 UTC 
FEDORA-2022-ec7eb3a63a has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-ec7eb3a63a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-ec7eb3a63a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 9 Fedora Update System 2022-01-24 00:46:12 UTC 
FEDORA-2022-ec7eb3a63a has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.