Spec URL: https://music.fedorapeople.org/python-asyncmy.spec SRPM URL: https://music.fedorapeople.org/python-asyncmy-0.2.3-1.fc35.src.rpm Description: asyncmy is a fast asyncio MySQL driver, which reuses most of pymysql and aiomysql but rewrites the core protocol with Cython to speed it up. Fedora Account System Username: music Koji scratch builds: F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=81293004 F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=81293005 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=81293009
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. (ignore -- rpm-autospec is okay) - You deserve an award for those tests against a MySQL daemon. 🥇 ✅ Approved! ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 57 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-asyncmy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-asyncmy [x]: Package functions as described. [X]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [X]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/charset.cpython-310-x86_64-linux-gnu.so python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/connection.cpython-310-x86_64-linux-gnu.so python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/converters.cpython-310-x86_64-linux-gnu.so python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/cursors.cpython-310-x86_64-linux-gnu.so python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/errors.cpython-310-x86_64-linux-gnu.so python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/pool.cpython-310-x86_64-linux-gnu.so python3-asyncmy: /usr/lib64/python3.10/site-packages/asyncmy/protocol.cpython-310-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/long2ice/asyncmy/archive/v0.2.3/asyncmy-0.2.3.tar.gz : CHECKSUM(SHA256) this package : a103fe502879d06e23a423691f7c9c8656c8f7896ca2c49f4646bbdb66440bfb CHECKSUM(SHA256) upstream package : a103fe502879d06e23a423691f7c9c8656c8f7896ca2c49f4646bbdb66440bfb Requires -------- python3-asyncmy (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) python-asyncmy-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-asyncmy: python-asyncmy python3-asyncmy python3-asyncmy(x86-64) python3.10-asyncmy python3.10dist(asyncmy) python3dist(asyncmy) python-asyncmy-debugsource: python-asyncmy-debugsource python-asyncmy-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-asyncmy --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: SugarActivity, C/C++, fonts, Ocaml, PHP, Java, Perl, R, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review! Repository requested. (In reply to Major Hayden 🤠 from comment #1) > - You deserve an award for those tests against a MySQL daemon. 🥇 I can guarantee you it I wouldn’t have done it from scratch! Fortunately, I found a good example to rip off.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-asyncmy
FEDORA-2022-3d3a6d3277 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3d3a6d3277
FEDORA-2022-3d3a6d3277 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-29f3b329ac has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-29f3b329ac
FEDORA-2022-81afdf9f7d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-81afdf9f7d
FEDORA-2022-e065533ead has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e065533ead
FEDORA-2022-81afdf9f7d has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-81afdf9f7d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-81afdf9f7d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-29f3b329ac has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-29f3b329ac \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-29f3b329ac See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-e065533ead has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-e065533ead \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e065533ead See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-81afdf9f7d has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-e065533ead has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-29f3b329ac has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.