Bug 2041232 - Review Request: audiotube - AudioTube can search YouTube Music, list albums and artists.
Summary: Review Request: audiotube - AudioTube can search YouTube Music, list albums ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2041225
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-16 16:14 UTC by Onuralp SEZER
Modified: 2023-01-07 17:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-07 17:45:34 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Onuralp SEZER 2022-01-16 16:14:51 UTC
Spec URL: https://pagure.io/audiotube_rpm/raw/main/f/audiotube.spec
SRPM URL: https://pagure.io/audiotube_rpm/raw/main/f/audiotube-21.12-1.fc35.src.rpm
Description: AudioTube can search YouTube Music, list albums and artists, play automatically generated playlists, albums and allows to put your own playlist together.
Fedora Account System Username: thunderbirdtr

Comment 1 Neal Gompa 2022-01-22 17:52:51 UTC
Initial spec review:

> BuildRequires: yt-dlp
> BuildRequires: python3-ytmusicapi

These also need to be declared as "Requires" too.

Comment 2 Onuralp SEZER 2022-01-22 17:55:14 UTC
(In reply to Neal Gompa from comment #1)
> Initial spec review:
> 
> > BuildRequires: yt-dlp
> > BuildRequires: python3-ytmusicapi
> 
> These also need to be declared as "Requires" too.

Done !

Comment 3 Neal Gompa 2022-01-22 18:17:46 UTC
> Requires: 	   yt-dlp
Requires:      python3-ytmusicapi

Indentation is wacky here...

Comment 4 Neal Gompa 2022-01-22 18:18:42 UTC
> %description
> %{summary}

This should be "%{summary}." in the description simply to make rpmlint shut up.

> %prep
> %autosetup -n %{name}-%{version}

"-n %{name}-%{version}" is superfluous, since that's the default. Drop it.

Also, license files are not captured with a "%license" stanza. Add "%license
LICENSES/*" to the file list.

Comment 5 Onuralp SEZER 2022-01-22 18:36:07 UTC
All done!

Comment 6 Neal Gompa 2022-01-22 19:16:44 UTC
> %description
> %{summary}

Still not fixed.

Comment 7 Onuralp SEZER 2022-01-22 20:20:55 UTC
(In reply to Neal Gompa from comment #6)
> > %description
> > %{summary}
> 
> Still not fixed.

Fixed.

Comment 8 Neal Gompa 2022-01-22 23:02:58 UTC
Review notes:

[x]: Package follows Fedora Packaging Guidelines
[x]: Package builds and installs (when its BRs are installed)
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 9 Gwyn Ciesla 2022-01-24 16:59:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/audiotube

Comment 10 Package Review 2023-01-07 17:45:34 UTC
Package is now in repositories, closing review.


Note You need to log in before you can comment on or make changes to this bug.