Spec URL: https://pagure.io/kalk_rpm/raw/master/f/kalk.spec SRPM URL: https://pagure.io/kalk_rpm/blob/master/f/kalk-21.12-1.fc35.src.rpm Description: kalk is a convergent calculator for Plasma. Fedora Account System Username: thunderbirdtr
Initial spec review: > %description > %{summary} This should be "%{summary}." in the description simply to make rpmlint shut up. > %prep > %autosetup -n %{name}-%{version} "-n %{name}-%{version}" is superfluous, since that's the default. Drop it. Also, license files are not captured with a "%license" stanza. Add "%license LICENSES/*" to the file list.
MR added.
Spec file updated. (In reply to Neal Gompa from comment #1) > Initial spec review: > > > %description > > %{summary} > > This should be "%{summary}." in the description simply to make rpmlint shut > up. > > > %prep > > %autosetup -n %{name}-%{version} > > "-n %{name}-%{version}" is superfluous, since that's the default. Drop it. > > Also, license files are not captured with a "%license" stanza. Add "%license > LICENSES/*" to the file list.
Passes fedora-review but needs licenses added, have notified Onuralp.
Everything looks gravy, so... PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kalk
Package is now in repositories, closing review.