Spec URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-importmap-rails/rawhide/rubygem-importmap-rails.spec SRPM URL: https://github.com/fedora-distgit/rubygem-importmap-rails/raw/rawhide/rubygem-importmap-rails-1.0.1-1.fc36.src.rpm Description: Use ESM with importmap to manage modern JavaScript in Rails without transpiling or bundling. Fedora Account System Username: pvalena _ _ _ _ Package is needed to build Ruby on Rails 7.0. Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=81357308 Copr build: https://copr.fedorainfracloud.org/coprs/build/3190931 Checks: - Koji build: ok - Tests: ok - Syntax check: ok - rpmlint: ok Fedora-review: https://gist.github.com/12ab010c186b4d9ff45bcbd3191e582e
It bundles "ES Module Shims", doesn't it? Therefor it should have `bundled` provide.
I didn't realize, thanks! Will add.
Taking for review.
There are a few nits: * As mentioned the package should have a bundled provide of the JS library. * The BuildRequires section has triplicated mentions of Ruby -- specifically of `ruby`, `ruby(release)`, and `ruby >= 2.7.0`. * There is a newer version available: 1.0.2, which should be preferably packaged. Otherwise LGTM.
Fixed. SRPM: https://github.com/fedora-distgit/rubygem-importmap-rails/raw/rawhide/rubygem-importmap-rails-1.0.3-1.fc37.src.rpm Spec: https://raw.githubusercontent.com/fedora-distgit/rubygem-importmap-rails/rawhide/rubygem-importmap-rails.spec Diff: https://github.com/fedora-distgit/rubygem-importmap-rails/commit/1626badc475a814ee533aedbd2eb1f73f8377194 _ _ _ _ Copr build: https://copr.fedorainfracloud.org/coprs/build/3803489 Checks: - Tests: ok - Syntax check: ok - Reverse dependencies: ok - rpmlint: ok _ _ _ _ Update log: https://gist.github.com/5f55c4c3f4102f1c3f69e3132883c7b8 Test log: https://gist.github.com/1f77be83b99358843967cecff6cbbdae gem2rpm diff: https://gist.github.com/f8452aac96d060611e8d662a4458e9c2
LGTM.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-importmap-rails
Thanks!