Red Hat Bugzilla – Bug 204151
Review Request: perl-File-NFSLock - Perl module to do NFS (or not) locking
Last modified: 2014-06-23 13:01:37 EDT
Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-NFSLock.spec
SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-NFSLock-1.20-1.src.rpm
Program based of concept of hard linking of files being atomic across NFS.
This concept was mentioned in Mail::Box::Locker (which was originally
presented in Mail::Folder::Maildir). Some routine flow is taken from
there -- particularly the idea of creating a random local file, hard
linking a common file to the local file, and then checking the nlink
status. Some ideologies were not complete (uncache mechanism, shared
locking) and some coding was even incorrect (wrong stat index).
File::NFSLock was written to be light, generic, and fast.
I see there's an examples directory/script, but it's not included in %doc.
Let's include that, and this package is approved.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ source files match upstream:
+ latest version is being packaged.
+ BuildRequires are proper.
+ package builds in mock (5/x86_64)
+ rpmlint is silent.
+ final provides and requires are sane:
perl(File::NFSLock) = 1.20
perl-File-NFSLock = 1.20-1.fc5
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ %check is present and all tests pass:
All tests successful.
Files=12, Tests=161, 42 wallclock secs ( 0.69 cusr + 0.82 csys = 1.51 CPU)
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
+ not a web app.
examples added with chmod -x:
(In reply to comment #2)
> examples added with chmod -x:
Wrong url, it is
Built in devel. Thanks for the review.
I don't plan on doing a FC5 release except if somebody
asks for it.
So requested :)
*** Bug 1112166 has been marked as a duplicate of this bug. ***
Package Change Request
Package Name: perl-File-NFSLock
New Branches: el6 epel7
As requested in bug #1112166.
Git done (by process-git-requests).