Description of problem: Attached file name of Japanese charactor is mis-decoded in sub window when try to save that file on Windows browser. Main window (browser) has no problem. (I tried 2000 and XP, both same. Linux does not have problem) Version-Release number of selected component (if applicable): squirrelmail-1.4.8-1.fc5 How reproducible: 100% Steps to Reproduce: 1.Open e-mail with attached file named using Japanese font by Windows (IE or Firefox). 2.Click attached file to save. 3. Actual results: File name mis-decoded in this sub window. Expected results: File name should be same as main window Additional info: I found the fix in Japanese Squirrelmail forum http://www.squirrelmail.jp/ and it works fine. So I attach a diff file of mime.php. Please investigate it.
Created attachment 134993 [details] Diff file for mime.php
http://download.fedora.redhat.com/pub/fedora/linux/core/development/source/SRPMS/squirrelmail-1.4.8-2.fc6.src.rpm Please rebuild and test this squirrelmail-1.4.6-2. This is currently what is on track to be an update in all Fedora and RHEL distros. Does this satisfy this issue?
Yes. It works fine! Thank you.
squirrelmail-1.4.8-IE-Japanese-download-ugly-hack.patch ---- @@ -312,6 +313,14 @@ function formatBody($imap_stream, $messa } $body = ''; + if (!$charset_converted) { ---- Please turn on PHP display_errors on your test install and set PHP error_reporting to E_ALL. You are using uninitialized variable.
After updating squirrelmail to 1.4.8-3.fc5, my logs are being inundated with: Jan 22 11:52:33 server2 httpd: PHP Notice: Undefined variable: charset_converte d in /usr/share/squirrelmail/functions/mime.php on line 316 Jan 22 11:52:33 server2 httpd: PHP Notice: Undefined variable: charset in /usr/ share/squirrelmail/functions/mime.php on line 317 Jan 22 11:52:33 server2 last message repeated 2 times Did not see this in 1.4.8-1.
Did this part of the code did not change in Fedora's 1.4.8. Was the 1.4.8-1 you were using from a different source?
Created attachment 146259 [details] diff of mime.php from 1.4.8-1 to 1.4.8-3 fc5
No. I'm using the fedora binary packages from: http://mirrors.kernel.org/fedora/core/updates/5/ I couldn't wrap my head around what exactly is happening from looking at cvs, so I manually downloaded the SRPMS from the above for 1.4.8-1 and 1.4.8-3 and they do show that this code _did_ change from 1.4.8-1 to 1.4.8-3. attached diff.
this $charset_converted locally scoped variable looks like it's from some other piece of missing code/functionality. it's nonsensical, unless maybe it was meant to be declared static, but it isn't as is. Also, I don't see how $charset would match anything but the empty string in line 317, unless $charset is some magical global php variable. This patch needs to be pulled and sent upstream, or someone more knowledgeable than me has to fix it.
I have exactly the same problem with 1.4.8-3.fc5: Notice: Undefined variable: charset_converted in /usr/share/squirrelmail/functions/mime.php on line 316 Notice: Undefined variable: charset in /usr/share/squirrelmail/functions/mime.php on line 317 Notice: Undefined variable: charset in /usr/share/squirrelmail/functions/mime.php on line 317 Notice: Undefined variable: charset in /usr/share/squirrelmail/functions/mime.php on line 317 Notice: Undefined variable: squirrelmail_language in /usr/share/squirrelmail/functions/mime.php on line 605 Nigel
I have squirrelmail-1.4.8-4.fc5 Notice: Undefined variable: charset_converted in /usr/share/squirrelmail/functions/mime.php on line 316 Notice: Undefined variable: charset in /usr/share/squirrelmail/functions/mime.php on line 317 Notice: Undefined variable: charset in /usr/share/squirrelmail/functions/mime.php on line 317 Notice: Undefined variable: charset in /usr/share/squirrelmail/functions/mime.php on line 317
Is there any work around we can use while this is being fixed?
Same on SquirrelMail 1.4.8-4.fc6
Fedora apologizes that these issues have not been resolved yet. We're sorry it's taken so long for your bug to be properly triaged and acted on. We appreciate the time you took to report this issue and want to make sure no important bugs slip through the cracks. If you're currently running a version of Fedora Core between 1 and 6, please note that Fedora no longer maintains these releases. We strongly encourage you to upgrade to a current Fedora release. In order to refocus our efforts as a project we are flagging all of the open bugs for releases which are no longer maintained and closing them. http://fedoraproject.org/wiki/LifeCycle/EOL If this bug is still open against Fedora Core 1 through 6, thirty days from now, it will be closed 'WONTFIX'. If you can reporduce this bug in the latest Fedora version, please change to the respective version. If you are unable to do this, please add a comment to this bug requesting the change. Thanks for your help, and we apologize again that we haven't handled these issues to this point. The process we are following is outlined here: http://fedoraproject.org/wiki/BugZappers/F9CleanUp We will be following the process here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this doesn't happen again. And if you'd like to join the bug triage team to help make things better, check out http://fedoraproject.org/wiki/BugZappers
*** This bug has been marked as a duplicate of 229454 ***