Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace.git/plain/gpu-trace.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-rawhide-x86_64/07259430-gpu-trace/gpu-trace-2.12-1.fc41.src.rpm Description: gpu-trace is a tool intended to aid the collection process of gpuvis traces. Fedora Account System Username: dorinda
koji scratch build f34 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445554 rawhide https://koji.fedoraproject.org/koji/taskinfo?taskID=81445905 f35 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445665 f36 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445869 epel8 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445546 epel9 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445498
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
updated the spec file and srpm, here's the link to copr builds https://copr.fedorainfracloud.org/coprs/dorinda/gpu-trace/build/7242489/
(In reply to Dorinda from comment #3) > updated the spec file and srpm, here's the link to copr builds > https://copr.fedorainfracloud.org/coprs/dorinda/gpu-trace/build/7242489/ Thanks Dorinda, can you please update comment #0 with the new SPEC and SRPM url?
seems the update i made previously wasn't applied, updated now thanks :)
Fedora review tool is failing as the src.rpm provided is fc39 and it's looking for a fc41 build. Can you rebuild for Rawhide and update accordingly comment #0?
A first issue is Source0 URL within the spec file is broken. Could not download Source0: https://github.com/lostgoat/gpu-trace/archive/refs/tags/gpu-trace-2.12.tar.gz The correct download address seems to be https://github.com/lostgoat/gpu-trace/archive/refs/tags/v2.12.tar.gz
You don't need to update first comment, just post a new comment with new Spec URL: and SRPM URL: lines, this will be picked up by the fedora review bot. Also, correct URL for Source0 is : https://github.com/lostgoat/gpu-trace/archive/v2.12/gpu-trace-2.12.tar.gz which translates to: Source0: https://github.com/lostgoat/gpu-trace/archive/v%{version}-%{name}-%{version}.tar.gz See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
Sorry typo above, should read: Source0: https://github.com/lostgoat/gpu-trace/archive/v%{version}/%{name}-%{version}.tar.gz
Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace.git/plain/gpu-trace.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-rawhide-x86_64/07259004-gpu-trace/gpu-trace-2.12-1.fc41.src.rpm Description: gpu-trace is a tool intended to aid the collection process of gpuvis traces. Fedora Account System Username: dorinda
Spec Url: https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace.git/plain/gpu-trace.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-rawhide-x86_64/07259430-gpu-trace/gpu-trace-2.12-1.fc41.src.rpm
Looking at the spec file, I see: BuildRequires: make BuildRequires: gcc systemd-rpm-macros But there's no need for gcc, nothing to be compiled there. There's a SystemD unit shipped in the package but it's not properly handled within the spec file. Please refer to: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets on how to handle SystemD units. I also think systemd should be in Requires. You can also use `%_systemd_util_dir` instead of hardcoding the systemd path in `export SYSTEMD_SERVICE_PATH=/usr/lib/systemd` Looking at the upstream code, I see calls to `sudo`, `logname`, `gpuvis`, `perf`, `trace-cmd`. Requires on their existence are missing. Looks like there's no package providing `gpuvis` command, perhaps you need to package that one as well? As it brings up a rpc service socket listening on rpcServerPort = 47317 you may want to provide a firewalld service file as well to make it easy granting access to that port.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.