Bug 2042596 - Upgrade: More condition types are needed to better indicate UOCR status
Summary: Upgrade: More condition types are needed to better indicate UOCR status
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Telco Edge
Version: 4.10
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.12.0
Assignee: jun
QA Contact: yliu1
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-19 19:09 UTC by yliu1
Modified: 2024-04-30 18:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-04-30 18:04:53 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description yliu1 2022-01-19 19:09:52 UTC
Description of problem:
Currently, there is only 1 condition type under UOCR (as far as I see) for various error checks and the overall status, and the timestamp only changes when the the condition status changed/upgrade is completed. (This is standard behavior from meta after talking with Irina).
 
It would be best to split some of the validations out and add different stages so user knows what has been validated and what is currently being done. 

Some examples for additional condition types: 
- Ready  -> for overall status like it currently has
- SpecValidated -> Check spec format, required fields, etc
- CandidateClusersExist -> Checks if any spokes should be upgraded, and Ready status should become True if all clusters are already compliant, and reason could be "No cluster to upgrade"
- Started -> true if enforce policies were created for individual clusters, false if blocked by blockingCR etc.
- Stopped -> true if canaries failed, etc; false for in-progress or completed.

Version-Release number of selected component (if applicable):
4.10

How reproducible:
100%

Steps to Reproduce:
1. Create and enable UOCR with blockingCR
2. Observe UOCR status changes

Actual results:
Only 1 condition available while state changes, e.g., it was first blocked due to missing blockingCR, then waiting for blocking CR to finish, then started upgrade and waiting for policies to be compliant. But the lastTransitionTime does NOT change until status changed from False to True, this is confusing to user.

  conditions:
  - lastTransitionTime: "2022-01-19T17:53:22Z"
    message: The ClusterGroupUpgrade CR has all clusters compliant with all the managed
      policies
    reason: UpgradeCompleted
    status: "True"
    type: Ready


Expected results:
Better/More information is provided by UOCR conditions


Additional info:

Comment 1 yliu1 2022-10-28 20:43:36 UTC
We now have plenty of various condition types for different scenarios :)

Comment 2 Rory Thrasher 2024-04-30 18:04:53 UTC
OCP is no longer using Bugzilla and this bug appears to have been left in an orphaned state. If the bug is still relevant, please open a new issue in the OCPBUGS Jira project: https://issues.redhat.com/projects/OCPBUGS/summary


Note You need to log in before you can comment on or make changes to this bug.