Bug 2042722 - Please branch and build python-smmap in epel9
Summary: Please branch and build python-smmap in epel9
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: python-smmap
Version: epel9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Carl George 🤠
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2042719
TreeView+ depends on / blocked
 
Reported: 2022-01-20 02:21 UTC by Carl George 🤠
Modified: 2022-02-19 02:04 UTC (History)
5 users (show)

Fixed In Version: python-smmap-5.0.0-1.el9
Clone Of:
Environment:
Last Closed: 2022-02-19 02:04:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Carl George 🤠 2022-01-20 02:21:22 UTC
Please branch and build python-smmap in epel9.

If you do not wish to maintain python-smmap in epel9, or do not think you will be able to do this in a timely manner, I would be happy to be a co-maintainer of the package (FAS carlwgeorge).

Comment 1 Troy Dawson 2022-02-08 16:31:29 UTC
Any progress on this.
If you do not wish to maintain python-smmap in epel9, or do not think you will be able to do this in a timely manner, Carl said he would be a co-maintainer (FAS carlwgeorge)

Currently, the package requires python3-nose for it's %check, but python3-nose is being deprecated, and will not be going into epel9.
https://fedoraproject.org/wiki/Changes/DeprecateNose

I found that the following change fixes the spec and allows it to build properly on epel9, and fixes the package for Fedora.


@@ -24,7 +24,7 @@ Summary:        %{summary}
 %{?python_provide:%python_provide python3-%{modname}}
 BuildRequires:  python3-devel
 BuildRequires:  python3-setuptools
-BuildRequires:  python3-nose
+BuildRequires:  python3-pytest
 
 %description -n python3-%{modname} %{_description}
 
@@ -40,7 +40,7 @@ Python 3 version.
 %py3_install
 
 %check
-nosetests-%{python3_version} -v
+%{__python3} -m pytest -v
 
 %files -n python3-%{modname}
 %{python3_sitelib}/%{modname}-*.egg-info/


When it builds, the %check still runs and looks like this

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.2H1lvt
+ umask 022
+ cd /builddir/build/BUILD
+ cd smmap-3.0.1
+ /usr/bin/python3 -m pytest -v
============================= test session starts ==============================
platform linux -- Python 3.9.10, pytest-6.2.2, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /builddir/build/BUILD/smmap-3.0.1
collecting ... collected 9 items
smmap/test/test_buf.py::TestBuf::test_basics PASSED                      [ 11%]
smmap/test/test_mman.py::TestMMan::test_cursor PASSED                    [ 22%]
smmap/test/test_mman.py::TestMMan::test_memman_operation PASSED          [ 33%]
smmap/test/test_mman.py::TestMMan::test_memory_manager PASSED            [ 44%]
smmap/test/test_tutorial.py::TestTutorial::test_example PASSED           [ 55%]
smmap/test/test_util.py::TestMMan::test_region PASSED                    [ 66%]
smmap/test/test_util.py::TestMMan::test_region_list PASSED               [ 77%]
smmap/test/test_util.py::TestMMan::test_util PASSED                      [ 88%]
smmap/test/test_util.py::TestMMan::test_window PASSED                    [100%]
============================== 9 passed in 7.63s ===============================
+ RPM_EC=0
++ jobs -p
+ exit 0

Comment 2 Lubomír Sedlář 2022-02-09 07:03:18 UTC
Apologies about slow reply.
I granted Carl access to the package. Thank you for help on maintaining it.

Comment 3 Fedora Update System 2022-02-10 04:30:24 UTC
FEDORA-EPEL-2022-fa2059dc76 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-fa2059dc76

Comment 4 Fedora Update System 2022-02-11 02:03:02 UTC
FEDORA-EPEL-2022-fa2059dc76 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-fa2059dc76

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2022-02-19 02:04:30 UTC
FEDORA-EPEL-2022-fa2059dc76 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.