Bug 2042772
| Summary: | RFE: recognize "auto_reset_crashkernel" in /etc/kdump.conf | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | YongkuiGuo <yoguo> | ||||
| Component: | augeas | Assignee: | Laszlo Ersek <lersek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | YongkuiGuo <yoguo> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 9.0 | CC: | jmaloy, kkiwi, lersek, rjones | ||||
| Target Milestone: | rc | Keywords: | FutureFeature, Triaged | ||||
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | augeas-1.13.0-2.el9 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2022-11-15 10:11:04 UTC | Type: | Feature Request | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This is not a regression, but a feature request for augeas. The "auto_reset_crashkernel" keyword was introduced in the following kexec-tools patch set: [PATCH v5 00/13] crashkernel=auto: support fadump and remove crashkernel.default https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/thread/V5WPTRAPJR65QXSTNW6W6E7ZBAUCQNUH/#V5WPTRAPJR65QXSTNW6W6E7ZBAUCQNUH Related upstream commit: https://src.fedoraproject.org/rpms/kexec-tools/c/73ced7f451a72 Ported to RHEL9 in the following dist-git commit (on the rhel-9.0.0 branch): 7ac560ef9ba0 ("introduce the auto_reset_crashkernel option to kdump.conf", 2022-01-06) Part of build kexec-tools-2.0.23-4.el9. Related RHEL9 bug: BZ#1895258 (In reply to Laszlo Ersek from comment #1) > This is not a regression, but a feature request for augeas. > ack, but what is the actual impact to augeas users / dependent packages (v2v?). Would the effort to add this support to augeas justify it? (In reply to Klaus Heinrich Kiwi from comment #2) > (In reply to Laszlo Ersek from comment #1) > > This is not a regression, but a feature request for augeas. > > > > ack, but what is the actual impact to augeas users / dependent packages > (v2v?). The *result* is certainly a regression. The augeas "lens" in question stops parsing the kdump.conf file as soon as it finds an unknown entry. Therefore *any* newly introduced keyword in kdump.conf, without prior coordination with the augeas and virt-v2v developers, will result in a regression for end-users. In other words, the new feature in kexec-tools caused the regression. > Would the effort to add this support to augeas justify it? I don't understand this question. Either the kexec-tools change must be backed out, or the missing part of the end-to-end feature (the augeas lens update namely) must be developed. I didn't mean that this BZ was not urgent, I only meant that, for the augeas component, this is a new feature, not a regression. Thanks! Apparently "parse this example file in my home dir with this lens" is an insurmountable challenge for augtool. I need to copy the example file (the attachment from comment#0) to tests/root/etc/kdump.conf so that the "filter" in "lenses/kdump.aug" match, relative to the "tests/root" directory, and then run ./src/try cli print /files/etc/kdump.conf Not over-engineered at all. /s (I tried the trick described here: <http://blog.alexanderhopgood.com/augeas/augtool/linux/2017/03/12/the-augtool.html>; it didn't work.) (In reply to Laszlo Ersek from comment #6) > https://github.com/hercules-team/augeas/pull/754 The CI run (at commit 31dfdc50f018, "Kdump: parse "auto_reset_crashkernel"", 2022-03-20) has succeeded; review pending. (In reply to Laszlo Ersek from comment #6) > https://github.com/hercules-team/augeas/pull/754 Merged as upstream commit 288a028da531 ("Kdump: parse "auto_reset_crashkernel" (#754)", 2022-04-20). Test with augeas-1.13.0-2.el9: Steps: 1. On rhel9.1 host # augtool print /files/etc/kdump.conf /files/etc/kdump.conf ... /files/etc/kdump.conf/auto_reset_crashkernel = "yes" /files/etc/kdump.conf/path = "/var/crash" /files/etc/kdump.conf/core_collector = "makedumpfile -l --message-level 7 -d 31" /files/etc/kdump.conf/#comment[148] = "core_collector scp" /files/etc/kdump.conf/#comment[149] = "kdump_post /var/crash/scripts/kdump-post.sh" /files/etc/kdump.conf/#comment[150] = "kdump_pre /var/crash/scripts/kdump-pre.sh" /files/etc/kdump.conf/#comment[151] = "extra_bins /usr/bin/lftp" /files/etc/kdump.conf/#comment[152] = "extra_modules gfs2" /files/etc/kdump.conf/#comment[153] = "failure_action shell" /files/etc/kdump.conf/#comment[154] = "force_rebuild 1" /files/etc/kdump.conf/#comment[155] = "force_no_rebuild 1" /files/etc/kdump.conf/#comment[156] = "dracut_args --omit-drivers \"cfg80211 snd\" --add-drivers \"ext2 ext3\"" /files/etc/kdump.conf/#comment[157] = "fence_kdump_args -p 7410 -f auto -c 0 -i 10" /files/etc/kdump.conf/#comment[158] = "fence_kdump_nodes node1 node2" The kdump.conf can be parsed correctly. Verified this bug since the test case for this bug has been automated and passed in the latest nightly compose test. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (augeas bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:8017 |
Created attachment 1852075 [details] /etc/kdump.conf Description of problem: augeas fails to parse /etc/kdump.conf file in RHEL-9.0.0-20220118.2 compose. The next new line is added into /etc/kdump.conf file which causes this issue. # cat /etc/kdump.conf ... auto_reset_crashkernel yes ... Version-Release number of selected component (if applicable): augeas-1.13.0-1.el9.x86_64 kernel-5.14.0-44.el9.x86_64 kexec-tools-2.0.23-5.el9.x86_64 How reproducible: 100% Steps: 1. On rhel9 host with RHEL-9.0.0-20220118.2 compose # augtool print /files/etc/kdump.conf There is no output. 2. # augtool print /augeas//error | grep kdump.conf /augeas/files/etc/kdump.conf/error = "parse_failed" /augeas/files/etc/kdump.conf/error/pos = "8436" /augeas/files/etc/kdump.conf/error/line = "179" /augeas/files/etc/kdump.conf/error/char = "0" /augeas/files/etc/kdump.conf/error/lens = "/usr/share/augeas/lenses/dist/kdump.aug:79.10-.39:" /augeas/files/etc/kdump.conf/error/lens/last_matched = "/usr/share/augeas/lenses/dist/kdump.aug:38.23-.33:" /augeas/files/etc/kdump.conf/error/message = "Iterated lens matched less than it should" Actual results: As above Expected results: augeas can parse /etc/kdump.conf file. Additional info: