Bug 2042789 - Review Request: ibus-engine-gui-ci - GUI CI for IBus engines
Summary: Review Request: ibus-engine-gui-ci - GUI CI for IBus engines
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-20 07:06 UTC by fujiwara
Modified: 2022-02-22 08:27 UTC (History)
3 users (show)

Fixed In Version: ibus-engine-gui-ci-1.0.0.20220118-1.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-22 08:27:58 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description fujiwara 2022-01-20 07:06:34 UTC
Spec URL: https://fujiwara.fedorapeople.org/ibus/engine-gui-ci/ibus-engine-gui-ci.spec
SRPM URL: https://fujiwara.fedorapeople.org/ibus/engine-gui-ci/ibus-engine-gui-ci-1.0.0.20220118-1.fc35.src.rpm
Description: 
GUI CI can run with ibus-desktop-testing-runner and engines get
focus events with the window manager.
Fedora Account System Username: fujiwara

Comment 1 Parag AN(पराग) 2022-02-03 10:27:25 UTC
Add missing BuildRequires:
BuildRequires:  git
BuildRequires:  gtk3-devel

Comment 2 fujiwara 2022-02-03 11:23:34 UTC
Thank you.

I updated https://fujiwara.fedorapeople.org/ibus/engine-gui-ci/ibus-engine-gui-ci.spec

Comment 3 Parag AN(पराग) 2022-02-04 04:54:53 UTC
running fedora-review tool on this package SRPM gave below output

Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/libexec/installed-tests,
     /usr/share/installed-tests

[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0: https://github.com/fujiwarat/ibus-
     engine-gui-ci/releases/download/1.0.0.20220118/ibus-engine-gui-
     ci-1.0.0.20220118.tar.gz
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/SourceURL/

Comment 5 Parag AN(पराग) 2022-02-04 08:13:09 UTC
one last thing though minor. We don't use now Group: tag. Please remove it before importing this package in Fedora
Read https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

Otherwise packaging looks good now.

APPROVED.

Comment 6 Gwyn Ciesla 2022-02-15 14:26:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ibus-engine-gui-ci


Note You need to log in before you can comment on or make changes to this bug.