RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2043004 - e2fsprogs: Rebase to the latest upstream release version 1.46.5
Summary: e2fsprogs: Rebase to the latest upstream release version 1.46.5
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: e2fsprogs
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Lukáš Czerner
QA Contact: Boyang Xue
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-20 13:23 UTC by Lukáš Czerner
Modified: 2022-05-17 16:37 UTC (History)
1 user (show)

Fixed In Version: e2fsprogs-1.46.5-2.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-17 16:02:33 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-108960 0 None None None 2022-01-20 13:47:02 UTC
Red Hat Product Errata RHBA-2022:4043 0 None None None 2022-05-17 16:02:34 UTC

Description Lukáš Czerner 2022-01-20 13:23:55 UTC
Description of problem:

Rebase to the latest upstream release version 1.46.5

Comment 2 Boyang Xue 2022-01-28 03:34:37 UTC
I find the minimal size for the new resize2fs is lifted comparing to the old version.

log of old version - e2fsprogs-1.46.2-2.el9.x86_64
```
# losetup -f --show 1G.img
# mkfs.ext4 /dev/loop0 256M
# resize2fs /dev/loop0 16M
resize2fs 1.46.2 (28-Feb-2021)
Resizing the filesystem on /dev/loop0 to 16384 (1k) blocks.
The filesystem on /dev/loop0 is now 16384 (1k) blocks long.
# e2fsck /dev/loop0
e2fsck 1.46.2 (28-Feb-2021)
/dev/loop0: clean, 11/4096 files, 9239/16384 blocks
```

log of new version - e2fsprogs-1.46.5-1.el9.x86_64
```
# losetup -f --show 1G.img
# mkfs.ext4 /dev/loop0 256M
# resize2fs /dev/loop0 26M

resize2fs 1.46.5 (30-Dec-2021)
resize2fs: New size smaller than minimum (27049)
```

Shrinking from 256M to 16M is fine in the old version, while the minimal size is as large as ~27M in the new version. @lczerner Is it a problem or expected?

Comment 3 Lukáš Czerner 2022-01-28 11:35:31 UTC
(In reply to Boyang Xue from comment #2)
> I find the minimal size for the new resize2fs is lifted comparing to the old
> version.
> 
> log of old version - e2fsprogs-1.46.2-2.el9.x86_64
> ```
> # losetup -f --show 1G.img
> # mkfs.ext4 /dev/loop0 256M
> # resize2fs /dev/loop0 16M
> resize2fs 1.46.2 (28-Feb-2021)
> Resizing the filesystem on /dev/loop0 to 16384 (1k) blocks.
> The filesystem on /dev/loop0 is now 16384 (1k) blocks long.
> # e2fsck /dev/loop0
> e2fsck 1.46.2 (28-Feb-2021)
> /dev/loop0: clean, 11/4096 files, 9239/16384 blocks
> ```
> 
> log of new version - e2fsprogs-1.46.5-1.el9.x86_64
> ```
> # losetup -f --show 1G.img
> # mkfs.ext4 /dev/loop0 256M
> # resize2fs /dev/loop0 26M
> 
> resize2fs 1.46.5 (30-Dec-2021)
> resize2fs: New size smaller than minimum (27049)
> ```
> 
> Shrinking from 256M to 16M is fine in the old version, while the minimal
> size is as large as ~27M in the new version. @lczerner Is it a
> problem or expected?

Nice catch, good job. So this is because the rebase also changed the mke2fs.conf in that we no longer want to use 128 bytes inodes by default. It is considered deprecated and instead we're always defaulting to 256 bytes inodes. This is because 128 byte inodes can't handle dates past year 2038.

Previously, and this is true for the version 1.46.2-2 as well, we have used 256 bytes inodes by default except in the usage types small and floppy; that is file systems smaller than 512M and 3M respectively. This update changes that in RHEL9 and we're using 256 bytes inodes even with those smaller file systems. Since the inode tables are now larger this will have an effect on the minimum resize size. I think this really is marginal and overall the change is a benefit. Moreover given that this is for RHEL9.0 I think we can, and should, make this change to be on par with upstream since the beginning.

You can test it by checking the inode size on the file system itself (tune2fs -l) when using different versions as well as specifying inode size (-I) manually.

To sum it up, it is expected behavior.

Thanks!
-Lukas

Comment 4 Boyang Xue 2022-01-29 09:32:27 UTC
(In reply to Lukáš Czerner from comment #3)
> (In reply to Boyang Xue from comment #2)
> > I find the minimal size for the new resize2fs is lifted comparing to the old
> > version.
> > 
> > log of old version - e2fsprogs-1.46.2-2.el9.x86_64
> > ```
> > # losetup -f --show 1G.img
> > # mkfs.ext4 /dev/loop0 256M
> > # resize2fs /dev/loop0 16M
> > resize2fs 1.46.2 (28-Feb-2021)
> > Resizing the filesystem on /dev/loop0 to 16384 (1k) blocks.
> > The filesystem on /dev/loop0 is now 16384 (1k) blocks long.
> > # e2fsck /dev/loop0
> > e2fsck 1.46.2 (28-Feb-2021)
> > /dev/loop0: clean, 11/4096 files, 9239/16384 blocks
> > ```
> > 
> > log of new version - e2fsprogs-1.46.5-1.el9.x86_64
> > ```
> > # losetup -f --show 1G.img
> > # mkfs.ext4 /dev/loop0 256M
> > # resize2fs /dev/loop0 26M
> > 
> > resize2fs 1.46.5 (30-Dec-2021)
> > resize2fs: New size smaller than minimum (27049)
> > ```
> > 
> > Shrinking from 256M to 16M is fine in the old version, while the minimal
> > size is as large as ~27M in the new version. @lczerner Is it a
> > problem or expected?
> 
> Nice catch, good job. So this is because the rebase also changed the
> mke2fs.conf in that we no longer want to use 128 bytes inodes by default. It
> is considered deprecated and instead we're always defaulting to 256 bytes
> inodes. This is because 128 byte inodes can't handle dates past year 2038.
> 
> Previously, and this is true for the version 1.46.2-2 as well, we have used
> 256 bytes inodes by default except in the usage types small and floppy; that
> is file systems smaller than 512M and 3M respectively. This update changes
> that in RHEL9 and we're using 256 bytes inodes even with those smaller file
> systems. Since the inode tables are now larger this will have an effect on
> the minimum resize size. I think this really is marginal and overall the
> change is a benefit. Moreover given that this is for RHEL9.0 I think we can,
> and should, make this change to be on par with upstream since the beginning.
> 
> You can test it by checking the inode size on the file system itself
> (tune2fs -l) when using different versions as well as specifying inode size
> (-I) manually.
> 
> To sum it up, it is expected behavior.
> 
> Thanks!
> -Lukas

Good to know. Thanks for the information! I find the 128 byte inode_size to 256 byte inode_size conversion happened in upstream commit

a23b50cd mke2fs: warn about missing y2038 support when formatting fresh ext4 fs

Comment 13 errata-xmlrpc 2022-05-17 16:02:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: e2fsprogs), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:4043


Note You need to log in before you can comment on or make changes to this bug.