Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2043070

Summary:	ptpfconfig update to new interface name , old interface metrics are retained
Product:	OpenShift Container Platform	Reporter:	obochan <obochan>
Component:	Cloud Native Events	Assignee:	Aneesh Puttur <aputtur>
Cloud Native Events sub component:	Cloud Event Proxy	QA Contact:	obochan <obochan>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	aos-bugs, aputtur, calfonso, ijolliff, jacding, keyoung
Version:	4.10
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-08 05:04:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description obochan 2022-01-20 15:08:14 UTC

Description of problem:
After deleting the running ptpconfig and apply new ones , the old interface metrics are retained


How reproducible:
Always

and you will see the old one weren't deleted.
Steps to Reproduce:
Get the metric via curl localhost:9091
delete the current running ptp configuration
apply new ptp config file
Get the metric via curl localhost:9091

Actual results:
metric of the old configuration are disabled

Expected results:
old metric are deleted and only new 


Additional info:

Comment 2 obochan 2022-01-23 08:11:19 UTC

It depends how you look at it , it doesn't block since the ptp works as expected but the metric that are part of the PTP are showing none-relevant information .

Comment 4 Aneesh Puttur 2022-02-24 15:57:21 UTC

*** Bug 2049092 has been marked as a duplicate of this bug. ***

Comment 5 obochan 2022-03-07 08:39:32 UTC

@aputtur you moved this issue to on QA since it is resolved, i don't see any PR attached.

Comment 7 obochan 2022-03-10 20:08:38 UTC

The issue isn't resolved as you can see below all the info.

[obochan@obochan ~]$ oc version 
Client Version: 4.8.0
Server Version: 4.10.4
Kubernetes Version: v1.23.3+e419edf
[obochan@obochan ~]$ 

openshift-ptp                                      ptp-operator.4.10.0-202203081809             PTP Operator                                             4.10.0-202203081809              Succeeded


the ptpconfig was running with ens7f1 and change it to ens5f1 and you can see the metrics for both after the change.

penshift_ptp_delay_ns{from="master",iface="ens5fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 83
openshift_ptp_delay_ns{from="master",iface="ens7fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 88
openshift_ptp_delay_ns{from="phc",iface="CLOCK_REALTIME",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="phc2sys"} 357
# HELP openshift_ptp_frequency_adjustment_ns 
# TYPE openshift_ptp_frequency_adjustment_ns gauge
openshift_ptp_frequency_adjustment_ns{from="master",iface="ens5fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} -2369
openshift_ptp_frequency_adjustment_ns{from="master",iface="ens7fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} -4023
openshift_ptp_frequency_adjustment_ns{from="phc",iface="CLOCK_REALTIME",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="phc2sys"} -80063
# HELP openshift_ptp_interface_role 0 = PASSIVE, 1 = SLAVE, 2 = MASTER, 3 = FAULTY, 4 =  UNKNOWN
# TYPE openshift_ptp_interface_role gauge
openshift_ptp_interface_role{iface="ens5f1",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 1
# HELP openshift_ptp_max_offset_ns 
# TYPE openshift_ptp_max_offset_ns gauge
openshift_ptp_max_offset_ns{from="master",iface="ens5fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 18
openshift_ptp_max_offset_ns{from="master",iface="ens7fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 20
openshift_ptp_max_offset_ns{from="phc",iface="CLOCK_REALTIME",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="phc2sys"} 10
# HELP openshift_ptp_offset_ns 
# TYPE openshift_ptp_offset_ns gauge
openshift_ptp_offset_ns{from="master",iface="ens5fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 8
openshift_ptp_offset_ns{from="master",iface="ens7fx",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="ptp4l"} 7
openshift_ptp_offset_ns{from="phc",iface="CLOCK_REALTIME",node="cnfde7.ptp.lab.eng.bos.redhat.com",process="phc2sys"} 10
# HELP openshift_ptp_threshold 
# TYPE openshift_ptp_threshold gauge
openshift_ptp_threshold{node="cnfde7.ptp.lab.eng.bos.redhat.com",profile="slave",threshold="HoldOverTimeout"} 5
openshift_ptp_threshold{node="cnfde7.ptp.lab.eng.bos.redhat.com",profile="slave",threshold="MaxOffsetThreshold"} 100
openshift_ptp_threshold{node="cnfde7.ptp.lab.eng.bos.redhat.com",profile="slave",threshold="MinOffsetThreshold"} -100
# HELP promhttp_metric_handler_requests_in_flight Current number of scrapes being served.

Comment 11 obochan 2022-04-05 06:23:57 UTC

The issue is verfied in 
[obochan@obochan ~]$ oc version 
Client Version: 4.8.0
Server Version: 4.10.6
Kubernetes Version: v1.23.5+b0357ed

[obochan@obochan ~]$ oc get csv -A | grep ptp
openshift-ptp                                      performance-addon-operator.v4.10.1           Performance Addon Operator                               4.10.1                                                     Succeeded
openshift-ptp                                      ptp-operator.4.10.0-202203111548             PTP Operator                                             4.10.0-202203111548                                        Succeeded


when changing the interface the previous interface metric were gone.

Comment 13 errata-xmlrpc 2022-04-08 05:04:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.10.8 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1162