Bug 2043166 - "Package Notes" patch breaks all ELN builds
Summary: "Package Notes" patch breaks all ELN builds
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-20 18:14 UTC by Stephen Gallagher
Modified: 2022-01-20 21:08 UTC (History)
12 users (show)

Fixed In Version: redhat-rpm-config-210-1.fc36
Clone Of:
Environment:
Last Closed: 2022-01-20 21:08:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Stephen Gallagher 2022-01-20 18:14:52 UTC
Description of problem:
The recently-introduced patch[1] results in all package builds in ELN failing with the error "line 31: syntax error near unexpected token `;'". This is due to the `%{__generate_package_note_file}` being undefined on ELN because the Requires: that pulls in package-notes-srpm-macros sits behind an `%if ! %{rhel}` conditional. Without that macro, the line consists only of a semicolon and it fails.

Version-Release number of selected component (if applicable):
redhat-rpm-config-209-1.fc36

How reproducible:
Every time, so long as the specified version is in the buildroot.


Additional info:
For the time being, I have untagged this version of redhat-rpm-config from the ELN buildroot.

[1] https://src.fedoraproject.org/rpms/redhat-rpm-config/c/57edf0cad7b089ed0193965b9a144aa4cfd7c25d?branch=rawhide

Comment 1 Miro Hrončok 2022-01-20 18:21:43 UTC
1) The rhel conditional thing should probably be fixed if we want this feature in ELN
2) %{?_generate_package_note_file} ; \ should be fixed as well

Comment 2 Miro Hrončok 2022-01-20 18:25:28 UTC
Added a fix for (2) in https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/169 (just to make sure my fix won't break ELN again)

Comment 3 Fedora Update System 2022-01-20 19:03:12 UTC
FEDORA-2022-ccd57ee818 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ccd57ee818

Comment 4 Fedora Update System 2022-01-20 21:08:58 UTC
FEDORA-2022-ccd57ee818 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.