Bug 2043581 - Review Request: aardvark-dns - Authoritative DNS server for A/AAAA container records
Summary: Review Request: aardvark-dns - Authoritative DNS server for A/AAAA container...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jindrich Novy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-21 14:58 UTC by Lokesh Mandvekar
Modified: 2022-02-25 16:51 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-25 16:51:47 UTC
Type: ---
Embargoed:
jnovy: fedora-review+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2022-01-21 14:58:16 UTC
Spec URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/aardvark-dns.spec
SRPM URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/SRPMS/aardvark-dns-0-1.fc35.src.rpm

Description:  Authoritative DNS server for A/AAAA container records

Fedora Account System Username: lsm5

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=81605289


rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

aardvark-dns.x86_64: W: unstripped-binary-or-object /usr/libexec/podman/aardvark-dns
aardvark-dns.x86_64: W: no-documentation

Comment 1 Jindrich Novy 2022-01-21 16:01:26 UTC
The package contains undefined macros:

Release: %autorelease
%autochangelog

Version: 0 ?

loads of useless commented out stuff:
#%%cargo_prep

#%%generate_buildrequires
#%%cargo_generate_buildrequires

I'd be more verbose than this:
%global _description %{expand:
%{summary}}

This one misses build requires?
ExclusiveArch: %{rust_arches}

The package is obviously autogenerated, please amend it so it meets basic packaging standards.

Comment 2 Lokesh Mandvekar 2022-01-21 17:42:03 UTC
Spec URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/aardvark-dns.spec
SRPM URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/SRPMS/aardvark-dns-0-0.1.gitbab0ac1.fc35.src.rpm


(In reply to Jindrich Novy from comment #1)
> The package contains undefined macros:
> 
> Release: %autorelease
> %autochangelog

See: https://docs.pagure.org/fedora-infra.rpmautospec/principle.html

I removed %autorelease since we don't have a versioned release upstream yet.
But let's keep %autochangelog.


> 
> Version: 0 ?

No upstream tag yet.

> 
> loads of useless commented out stuff:
> #%%cargo_prep
> 
> #%%generate_buildrequires
> #%%cargo_generate_buildrequires

Removed. I'd kept it as a reminder to anyone looking that rust2rpm doesn't work because dependencies missing, but anyway.

> 
> I'd be more verbose than this:
> %global _description %{expand:
> %{summary}}

done.

> 
> This one misses build requires?
> ExclusiveArch: %{rust_arches}

done.

Comment 3 Lokesh Mandvekar 2022-01-21 17:43:26 UTC
ugh i might need to change rpmautospec-rpm-macros.

Comment 5 Jindrich Novy 2022-01-25 12:49:22 UTC
Does upstream plan to do an initial release? I don't quite feel comfortable with putting unreleased content in Fedora.

I also see:
Version: 0

But changelog says it is 0.2.2?

Comment 6 Lokesh Mandvekar 2022-01-25 13:24:16 UTC
(In reply to Jindrich Novy from comment #5)
> Does upstream plan to do an initial release? I don't quite feel comfortable
> with putting unreleased content in Fedora.

Upstream will be cutting an initial tag soon. This won't be going into Fedora 34 at all. RE: f35, I can wait until we have an upstream tag.
But it would be nice to put it in rawhide soon as we can. netavark will need this and podman 4.0 should have netavark available.

> 
> I also see:
> Version: 0

Yes, because we don't have an upstream release yet.

> 
> But changelog says it is 0.2.2?

It said 0-0.2.gitBLAHBLAH. Now it should be 0-0.3.gitBLAHBLAH.

Spec URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/aardvark-dns.spec
SRPM URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/SRPMS/aardvark-dns-0-0.3.git43cd189.fc35.src.rpm

Comment 7 Jindrich Novy 2022-01-26 16:07:48 UTC
There are duplicated provides:

Provides: bundled(crate(env_logger)) = v0.8.4
Provides: bundled(crate(env_logger)) = v0.9.0

This binary is unstripped:

/usr/libexec/podman/aardvark-dns

Comment 8 Lokesh Mandvekar 2022-01-26 16:37:42 UTC
(In reply to Jindrich Novy from comment #7)
> There are duplicated provides:
> 
> Provides: bundled(crate(env_logger)) = v0.8.4
> Provides: bundled(crate(env_logger)) = v0.9.0

Both versions are vendored upstream currently. I'll check with upstream about using only 1, but not sure how long that's gonna take.
But I hope that's not a blocker.


> This binary is unstripped:
> 
> /usr/libexec/podman/aardvark-dns

Package fails to build with debuginfo enabled. Hope that's not a blocker either.

Comment 9 Jindrich Novy 2022-01-27 18:38:39 UTC
Ok, fair enough.

Comment 10 Gwyn Ciesla 2022-01-27 19:05:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/aardvark-dns

Comment 11 Fedora Update System 2022-01-28 21:16:45 UTC
FEDORA-2022-a1f597311f has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a1f597311f

Comment 12 Fedora Update System 2022-01-30 01:14:27 UTC
FEDORA-2022-a1f597311f has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a1f597311f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a1f597311f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-02-04 02:27:48 UTC
FEDORA-2022-2a101a0345 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-2a101a0345`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-2a101a0345

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-02-11 02:14:42 UTC
FEDORA-2022-5869f3225b has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-5869f3225b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5869f3225b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-02-18 02:12:06 UTC
FEDORA-2022-bc2075bf86 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-bc2075bf86`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc2075bf86

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-02-25 16:51:47 UTC
FEDORA-2022-bc2075bf86 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.