Bug 2044398 - SSP should not update DataSource managed by DataImportCron
Summary: SSP should not update DataSource managed by DataImportCron
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: SSP
Version: 4.10.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: 4.10.0
Assignee: Andrej Krejcir
QA Contact: Ruth Netser
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-24 14:17 UTC by Ruth Netser
Modified: 2022-03-16 16:07 UTC (History)
4 users (show)

Fixed In Version: kubevirt-ssp-operator v4.10.0-45
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-16 16:06:49 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt ssp-operator pull 294 0 None Merged Do not create DataImportCron if DataSource points to an existing PVC 2022-01-24 14:59:24 UTC
Github kubevirt ssp-operator pull 297 0 None open Fix DataSource reconciliation when DataImportCron template is removed 2022-01-27 15:33:36 UTC
Github kubevirt ssp-operator pull 300 0 None Merged [release-v0.13] Fix DataSource reconciliation when DataImportCron template is removed 2022-01-28 14:03:13 UTC
Red Hat Product Errata RHSA-2022:0947 0 None None None 2022-03-16 16:07:04 UTC

Description Ruth Netser 2022-01-24 14:17:03 UTC
Description of problem:
We found out that currently SSP reconciles edited/deleted DataSources.
For example: If a DataSource was updated by CDI and then a user manually updates it, SSP currently reconciles the resource, reverting any changes done by CDI.

Our purposed solution is to label a DataSource with its managing DataImportCron if and only if the DataImportCron controller is the one responsible for its updates, so SSP will not update it

Version-Release number of selected component (if applicable):
CNV 4.10

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Guohua Ouyang 2022-01-27 01:27:24 UTC
I tested with v4.10.0-617/kubevirt-ssp-operator-container-v4.10.0-41, it seems not the issue is not fixed.
Reproduce steps:
1. the auto-update boot source feature is enabled by default, the template boot source field is "Red Hat" on UI.
2. disable the auto-update boot source feature
3. upload a golden image to RHEL8 template manually, specify test provider "test".
4. enable the feature again
5. the RHEL8 template boot source changed to "Red Hat", it override the manual uploaded golden image.

Comment 3 Ruth Netser 2022-02-15 14:10:59 UTC
Verified with SSP operator v4.10.0-48 (along with bug 2051693)

Tested:
- Feature disabled - DAS is reconciled when deleted/edited
- Feature enabled (auto-update DV) - DAS and DIC are reconciled when deleted/edited
- Feature enabled (dangling DAS) - DAS is reconciled when deleted/edited
- Feature enabled, existing PVC (without dic label) - DAS is reconciled when deleted/edited, DIC is not created
- Feature enabled, existing PVC (without dic label) - delete existing PVC - DIC is created, auto-update DV is imported
- Feature enabled, existing PVC (add dic label) - DIC is created, DAS and DIC are reconciled when deleted/edited
- Feature enabled, existing PVC (add -> delete dic label) - DAS is reconciled when deleted/edited; DIC is deleted

Comment 7 errata-xmlrpc 2022-03-16 16:06:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.10.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0947


Note You need to log in before you can comment on or make changes to this bug.