Bug 2044454 - Handle sidebar section render that defines Adapter
Summary: Handle sidebar section render that defines Adapter
Keywords:
Status: CLOSED DUPLICATE of bug 2064256
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.9
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: Christoph Jerolimov
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-24 16:27 UTC by Jaivardhan Kumar
Modified: 2022-05-23 10:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-23 10:05:39 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 11420 0 None open Bug 2064256: Fix topology sidebar update issues 2022-05-03 11:13:48 UTC

Description Jaivardhan Kumar 2022-01-24 16:27:23 UTC
Description of problem:
renderNull property is introduced to the extension `console.topology/details/tab-section` for section that defines Adapter.

https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/src/extensions/topology-details.ts#L37-L42

as part of https://github.com/openshift/console/pull/10127

This change triggered a console warning that another component is updated while rendering the topology sidebar 

```
react_devtools_backend.js:4045 Warning: Cannot update a component (`SideBarTabLoader`) while rendering a different component (`BuildTabSection`)
```

as updates https://github.com/openshift/console/blob/master/frontend/packages/topology/src/components/side-bar/providers/SideBarTabLoader.tsx#L43-L56 


(which has been fixed https://github.com/openshift/console/pull/10842)

Above PR fixes the warning but not the actual render flow, if the section that defines the adapter needs to adapt then a hook /callback will be needed, it will render what is needed to show the tab.

Version-Release number of selected component (if applicable): 4.10



Additional info: slack thread https://coreos.slack.com/archives/CHGU4P8UU/p1642613543061800

Comment 3 Christoph Jerolimov 2022-05-23 10:05:39 UTC
This issue is solved with PR https://github.com/openshift/console/pull/11420 in 4.11.

As all these issues have the same root cause we mark this as a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=2064256

We will backport this back to 4.8.

*** This bug has been marked as a duplicate of bug 2064256 ***


Note You need to log in before you can comment on or make changes to this bug.