Bug 2044858
| Summary: | annocheck FAIL: bind-now test (fio) | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Rui Ormonde <rlemosor> |
| Component: | fio | Assignee: | Eric Sandeen <esandeen> |
| Status: | CLOSED ERRATA | QA Contact: | Samuel Petrovic <spetrovi> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 9.0 | CC: | jhladky, spetrovi |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | fio-3.27-7.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-17 14:09:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2044387 | ||
|
Description
Rui Ormonde
2022-01-25 10:29:53 UTC
I think this can be fixed by simply including $(LDFLAGS) appropriately in the Makefile: --- a/Makefile.orig 2022-01-25 10:20:26.862377137 -0600 +++ b/Makefile 2022-01-25 10:20:30.061327891 -0600 @@ -287,7 +287,7 @@ $(1)_OBJS := $$($(1)_SRCS:.c=.o) $$($(1)_OBJS): CFLAGS := -fPIC $$($(1)_CFLAGS) $(CFLAGS) engines/fio-$(1).so: $$($(1)_OBJS) - $$(QUIET_LINK)$(CC) -shared -rdynamic -fPIC -Wl,-soname,fio-$(1).so.1 -o $$@ $$< $$($(1)_LIBS) + $$(QUIET_LINK)$(CC) $(LDFLAGS) -shared -rdynamic -fPIC -Wl,-soname,fio-$(1).so.1 -o $$@ $$< $$($(1)_LIBS) ENGS_OBJS += engines/fio-$(1).so endef else # !CONFIG_DYNAMIC_ENGINES This is upstream now. https://git.kernel.dk/cgit/fio/commit/?id=2b3d4a6a924e0aa82654d3b96fb134085af7a98a Hi Samuel, I'd like to fix this one for 9.0.0 - if you agree can you set qe_ack? I already set a DTM but feel free to change it. Thanks, -Eric It took longer to achieve the change than I expected so moving DTM out by one. However, to verify this (get it into verified-tested?) it should be simple enough; just looking at the build logs we now see the proper hardening flags which were not there before. Before: http://download.eng.bos.redhat.com/brewroot/packages/fio/3.27/4.el9/data/logs/x86_64/build.log gcc -shared -rdynamic -fPIC -Wl,-soname,fio-nbd.so.1 -o engines/fio-nbd.so engines/nbd.o -lnbd gcc -shared -rdynamic -fPIC -Wl,-soname,fio-libaio.so.1 -o engines/fio-libaio.so engines/libaio.o -laio gcc -shared -rdynamic -fPIC -Wl,-soname,fio-rdma.so.1 -o engines/fio-rdma.so engines/rdma.o -libverbs -lrdmacm gcc -shared -rdynamic -fPIC -Wl,-soname,fio-rados.so.1 -o engines/fio-rados.so engines/rados.o -lrados gcc -shared -rdynamic -fPIC -Wl,-soname,fio-rbd.so.1 -o engines/fio-rbd.so engines/rbd.o -lrbd -lrados gcc -shared -rdynamic -fPIC -Wl,-soname,fio-http.so.1 -o engines/fio-http.so engines/http.o -lcurl -lssl -lcrypto gcc -shared -rdynamic -fPIC -Wl,-soname,fio-pmemblk.so.1 -o engines/fio-pmemblk.so engines/pmemblk.o -lpmemblk gcc -shared -rdynamic -fPIC -Wl,-soname,fio-dev-dax.so.1 -o engines/fio-dev-dax.so engines/dev-dax.o -lpmem gcc -shared -rdynamic -fPIC -Wl,-soname,fio-libpmem.so.1 -o engines/fio-libpmem.so engines/libpmem.o -lpmem After: http://download.eng.bos.redhat.com/brewroot/packages/fio/3.27/7.el9/data/logs/x86_64/build.log gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-nbd.so.1 -o engines/fio-nbd.so engines/nbd.o -lnbd gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-libaio.so.1 -o engines/fio-libaio.so engines/libaio.o -laio gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-rdma.so.1 -o engines/fio-rdma.so engines/rdma.o -libverbs -lrdmacm gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-rados.so.1 -o engines/fio-rados.so engines/rados.o -lrados gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-rbd.so.1 -o engines/fio-rbd.so engines/rbd.o -lrbd -lrados gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-http.so.1 -o engines/fio-http.so engines/http.o -lcurl -lssl -lcrypto gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-pmemblk.so.1 -o engines/fio-pmemblk.so engines/pmemblk.o -lpmemblk gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-dev-dax.so.1 -o engines/fio-dev-dax.so engines/dev-dax.o -lpmem gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -rdynamic -shared -rdynamic -fPIC -Wl,-soname,fio-libpmem.so.1 -o engines/fio-libpmem.so engines/libpmem.o -lpmem thanks, -Eric Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (new packages: fio), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:2659 |