RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2044882 - annocheck FAIL: fortify test (nvml)
Summary: annocheck FAIL: fortify test (nvml)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: nvml
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 9.0
Assignee: Bryan Gurney
QA Contact: xiaoli feng
URL:
Whiteboard:
Depends On:
Blocks: 2044387
TreeView+ depends on / blocked
 
Reported: 2022-01-25 10:35 UTC by Rui Ormonde
Modified: 2022-05-17 12:41 UTC (History)
3 users (show)

Fixed In Version: nvml-1.10.1-2.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-17 12:29:36 UTC
Type: ---
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-109533 0 None None None 2022-01-25 10:42:10 UTC
Red Hat Product Errata RHBA-2022:2323 0 None None None 2022-05-17 12:29:46 UTC

Description Rui Ormonde 2022-01-25 10:35:23 UTC 
Failed test: fortify test

Test results:
\n Hardened: libpmem.so.1.0.0: FAIL: fortify test because -O level is too low

Applicable RPMs:
libpmem-debug-1.10.1-1.el9.ppc64le.rpm; libpmem-debug-1.10.1-1.el9.x86_64.rpm; libpmem2-debug-1.10.1-1.el9.ppc64le.rpm; libpmem2-debug-1.10.1-1.el9.x86_64.rpm; libpmemblk-debug-1.10.1-1.el9.ppc64le.rpm; libpmemblk-debug-1.10.1-1.el9.x86_64.rpm; libpmemlog-debug-1.10.1-1.el9.ppc64le.rpm; libpmemlog-debug-1.10.1-1.el9.x86_64.rpm; libpmemobj-debug-1.10.1-1.el9.ppc64le.rpm; libpmemobj-debug-1.10.1-1.el9.x86_64.rpm; libpmempool-debug-1.10.1-1.el9.ppc64le.rpm; libpmempool-debug-1.10.1-1.el9.x86_64.rpm

Recommendation: Please fix the build system for the package or else add a skip of tests to the rpminspect.yaml file. For more details please see https://sourceware.org/annobin/annobin.html/Test-fortify.html and https://sourceware.org/annobin/annobin.html/Waiving-Hardened-Results.html#Waiving-Hardened-Results.

Why this bug was filed: All packages in RHEL 9 built with gcc (g++, etc.) are required to use a common set of flags provided by the distribution. These flags turn on important security and performance features so it is critical that any package that lacks these flags be repaired. A scanning tool named annocheck, part of the annobin package, was used to scan RHEL 9 packages. This BZ was created because binary packages of this component with the mentioned NVRs were not built with the requisite flags for one or more RHEL 9 architectures.

How to reproduce the failure: You could try running annocheck locally against your builds: https://developers.redhat.com/blog/2019/02/04/annocheck-examining-the-contents-of-binary-files.

Annocheck resources:
* annobin documentation: https://sourceware.org/annobin/annobin.html/index.html
* annocheck on the customer portal: https://access.redhat.com/documentation/en-us/red_hat_developer_toolset/9/html/user_guide/chap-annobin

Contacts:
* Instant messaging: #tools on IRC
* Email: use tools for generic questions. Otherwise, use go-tools and llvm-clang-list for Go and Clang/LLVM specific questions.
* annobin-annocheck maintainer: Nick Clifton (nickc)
Comment 2 Jeff Moyer 2022-01-25 16:45:21 UTC 
Nick, this source package builds -debug packages which have optimization turned off.  Is there a way to automatically waive the result only for those packages?
Comment 3 Nick Clifton 2022-01-25 17:46:26 UTC 
Hi Jeff,

  No, I do not think that there is. :-(

  We should probably check with David Cantrell as he is the expert on rpminspect, 
  but based upon what I have seen, adding annocheck skip options to the 
  rpminspect.yaml file is an all or nothing type of action.

  On the other hand skipping the optimization check for all of the rpms would not
  be too terrible.  The optimization test is there because -O2 (or better) is
  needed in order to make -D_FORTIFY_SOURCE=2 work.  (At lower optimizations the
  compiler does not do enough analysis to make the fortification effective).  But
  given that you are compiling the "real" binaries with -O2 then I do not think 
  that it would matter if you skip the check for them.

Cheers
  Nick

PS. It would probably be a good idea to put a line or two about this as a comment
  in the rpminspect.yaml file, so that future readers can see what is going on.
Comment 4 Jeff Moyer 2022-01-25 18:55:06 UTC 
OK, thanks a lot for the reply, Nick!
Comment 5 Bryan Gurney 2022-02-03 16:45:37 UTC 
Posted CentOS Stream merge request to https://gitlab.com/redhat/centos-stream/rpms/nvml/-/merge_requests/10
Comment 10 errata-xmlrpc 2022-05-17 12:29:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: nvml), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2323
Note You need to log in before you can comment on or make changes to this bug.