Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-1.noarch.rpm Description: Another Python DNS library, this one is based on Guido's original code, updated by Anthony Baxter. It is required for the PySPF package. This is my first package and I need a sponsor.
I'd be happy to take a look at this (and pyspf). Your SRPM link seems to be pointing to the noarch instead of the src.rpm... can you provide an updated link? :)
OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - Package compiles and builds on at least one arch. OK - BuildRequires correct See below - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: See below - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. Should the license really be "Python Software Foundation License" and not "Python license" ? a grep in the unpacked source gives: PKG-INFO:License: Python license README.txt:This code is released under a Python-style license. setup.py: license = 'Python license', 2. You should provide a full path to the source in Source0. Perhaps something like: Source0: http://easynews.dl.sourceforge.net/sourceforge/pydns/ pydns-%{version}.tgz 3. You need to own the %{python_sitelib}/DNS/ directory, not just it's contents. 4. rpmlint says: W: python-pydns summary-ended-with-dot Python module for DNS (Domain Name Service). Suggest: remove the . at the end of the summary line. 5. You BuildRequire python-setuptools, according to the python package guidelines ( at http://fedoraproject.org/wiki/Packaging/Python ), "Python packages that use setuptools need to add python-setuptools as a BuildRequires and must either add --single-version-externally-managed to the line invoking setup.py in %install, or must add a .pth file containing the path to the egg or egg directory to %{python_sitelib}." Should this package do that? Or does it really need python-setuptools at all?
Sorry about that. Here's the SRPM: SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-1.src.rpm
Thanks for the pointers, Kevin. Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-2.src.rpm
ok, all the 5 issues above from comment #2 are fixed... one new thing however, you're missing a changelog entry for the -2 release. Fix that up and I think this will be all ready for approval.
I've changed this to include a changelog for -3. I hope this is ok, as I pretty much consider everything <-3 to be part of the initial packaging, since I haven't released them otherwise. Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-3.src.rpm
This version has changelog entries for the -2 Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-4.src.rpm
looks good. This package is APPROVED. I'd be happy to sponsor you... Continue the process from the "get a fedora account" section on: http://www.fedoraproject.org/wiki/Extras/Contributors
The package was imported and built.
Package Change Request ====================== Package Name: python-pydns New Branches: EL-5 To get into EPEL.
branch done.