Fedora Account System
Red Hat Associate
Red Hat Customer
Description of problem: git send-email --to='gitlab.incoming+datovka-libdatovka-1025-c5xvb0b6zbp5dsd9t8lf5y7ab-merge-request' patch.patch fails Version-Release number of selected component (if applicable): git-2.34.1-1.fc34.x86_64 How reproducible: Always Steps to Reproduce: 1. git send-email --to='gitlab.incoming+datovka-libdatovka-1025-c5xvb0b6zbp5dsd9t8lf5y7ab-merge-request' patch.patch 2. 3. Actual results: error: unable to extract a valid address from: gitlab.incoming+datovka-libdatovka-1025-c5xvb0b6zbp5dsd9t8lf5y7ab-merge-request Expected results: no error Additional info: This is valid address
This is fallout from 4414f61 (add more git-email perl dependencies, 2021-11-13)¹. I don't believe it is a strictly valid address. The local-part is longer than the allowed 64 octets² and the perl Email::Valid module which git send-email uses tests this restriction³. $ echo -n 'gitlab.incoming+datovka-libdatovka-1025-c5xvb0b6zbp5dsd9t8lf5y7ab-merge-request' | wc -c 79 I'm not sure that it's a good idea to disable that. Maybe it would be handy to have a way to override it if you know that all the mail tools in your path will handle it. (Though it's clear that any which strictly adhere to the RFC's are likely to reject it.) That is likely something that would need to be discussed on the git list to arrive at a consensus (and a patch). It's not something I feel we should try to patch out of git in Fedora. ¹ https://src.fedoraproject.org/rpms/git/c/4414f61 ² https://datatracker.ietf.org/doc/html/rfc5321#section-4.5.3.1.1 ³ https://github.com/Perl-Email-Project/Email-Valid/blob/master/lib/Email/Valid.pm#L297-L303
Thanks for info. It would be great to have an option to override this check. Or it could ask: this is not valid address according to RFC, do you want to still send the e-mail? It seems this address is ad-hoc gitlab generated for pull requests via e-mail. The length depends on the project name. I have to contribute to such projects by using different tool than the git-send-email which is a bit complication. It seems for me all such e-mails arrived, so the support in the major mailing tools is probably available. Could you please bring it to the upstream? And close this with the resolution upstream and link to the upstream ticket. Thanks.
This message is a reminder that Fedora Linux 34 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '34'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 34 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07. Fedora Linux 34 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. Thank you for reporting this bug and we are sorry it could not be fixed.
I submitted a patch upstream to add a `--no-validate-email` option that would solve this issue for you if you did want to skip all forms of email address validation: http://public-inbox.org/git/20220620004427.3586240-1-trawets@amazon.com/T/#u