Bug 2046598 - Auto-update boot source size unit is byte on customize wizard
Summary: Auto-update boot source size unit is byte on customize wizard
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.10
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.11.0
Assignee: Guohua Ouyang
QA Contact: Guohua Ouyang
URL:
Whiteboard:
: 2049412 (view as bug list)
Depends On:
Blocks: 2078699 2099439
TreeView+ depends on / blocked
 
Reported: 2022-01-27 03:39 UTC by Guohua Ouyang
Modified: 2022-08-10 10:44 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 10:44:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
disk size unit is byte (2.62 MB, application/octet-stream)
2022-01-27 03:39 UTC, Guohua Ouyang
no flags Details
disk unit on customize wizard (1.46 MB, application/octet-stream)
2022-02-23 11:10 UTC, Guohua Ouyang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 11024 0 None Merged Bug 2046598: Display disk size in GiB in VM customize wizard 2022-02-22 04:55:19 UTC
Github openshift console pull 11104 0 None open Bug 2046598: Display disk size in correct units 2022-02-24 23:47:39 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:44:28 UTC

Description Guohua Ouyang 2022-01-27 03:39:13 UTC
Created attachment 1855682 [details]
disk size unit is byte

Description of problem:
Auto-update boot source size is calculated in byte on customize wizard, which is hard to read, it should use 'GiB' instead of Byte.

Version-Release number of selected component (if applicable):
master

How reproducible:
100%

Steps to Reproduce:
1. create vm from template which boot source is auto-updated, like template rhel9
2.
3.

Actual results:
It use "B" for disk size

Expected results:
It use "GiB" for disk size

Additional info:
It does not happen to user uploaded golden images.

Comment 2 Tal Nisan 2022-02-07 14:39:13 UTC
*** Bug 2049412 has been marked as a duplicate of this bug. ***

Comment 3 Guohua Ouyang 2022-02-09 02:48:59 UTC
set this to high, this is a very annoying issue and could cause unexpected behavior. An example is:
on the customize wizard, if a user edits the disk and saves it, it could create a very large disk (1000 PiB) without attention.

We need to fix this issue and backport to 4.10.z.

Comment 4 Guohua Ouyang 2022-02-16 04:42:44 UTC
(In reply to Guohua Ouyang from comment #3)
> set this to high, this is a very annoying issue and could cause unexpected
> behavior. An example is:
> on the customize wizard, if a user edits the disk and saves it, it could
> create a very large disk (1000 PiB) without attention.

create a new bug https://bugzilla.redhat.com/show_bug.cgi?id=2054950 for the disk modal because the current fix of this bug won't take care of it.

Comment 7 Guohua Ouyang 2022-02-23 11:10:19 UTC
Created attachment 1862928 [details]
disk unit on customize wizard

Tested on master, the disk unit is still 'B' if the template has no boot source.
Another problem the disk unit even uses 'B' after modifying it with other values.

Comment 10 Guohua Ouyang 2022-02-28 01:47:56 UTC
Tests should cover three scenarios:
1. create VM from template has no boot source
2. create VM from template has manual updated boot source
3. create VM from template which has auto-updated boot source

Test on master which has the PR included, the first 2 scenarios are PASS, but failed on the scenario 3.

Comment 11 Guohua Ouyang 2022-03-23 05:53:54 UTC
This bug is similar with https://bugzilla.redhat.com/show_bug.cgi?id=2054950
And not reproduced on latest master

Comment 13 errata-xmlrpc 2022-08-10 10:44:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.