Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2046598

Summary: Auto-update boot source size unit is byte on customize wizard
Product: OpenShift Container Platform Reporter: Guohua Ouyang <gouyang>
Component: Console Kubevirt PluginAssignee: Guohua Ouyang <gouyang>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: high Docs Contact:
Priority: high    
Version: 4.10CC: aos-bugs, gouyang, rnetser, tnisan
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-10 10:44:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2078699, 2099439    
Attachments:
Description Flags
disk size unit is byte
none
disk unit on customize wizard none

Description Guohua Ouyang 2022-01-27 03:39:13 UTC
Created attachment 1855682 [details]
disk size unit is byte

Description of problem:
Auto-update boot source size is calculated in byte on customize wizard, which is hard to read, it should use 'GiB' instead of Byte.

Version-Release number of selected component (if applicable):
master

How reproducible:
100%

Steps to Reproduce:
1. create vm from template which boot source is auto-updated, like template rhel9
2.
3.

Actual results:
It use "B" for disk size

Expected results:
It use "GiB" for disk size

Additional info:
It does not happen to user uploaded golden images.

Comment 2 Tal Nisan 2022-02-07 14:39:13 UTC
*** Bug 2049412 has been marked as a duplicate of this bug. ***

Comment 3 Guohua Ouyang 2022-02-09 02:48:59 UTC
set this to high, this is a very annoying issue and could cause unexpected behavior. An example is:
on the customize wizard, if a user edits the disk and saves it, it could create a very large disk (1000 PiB) without attention.

We need to fix this issue and backport to 4.10.z.

Comment 4 Guohua Ouyang 2022-02-16 04:42:44 UTC
(In reply to Guohua Ouyang from comment #3)
> set this to high, this is a very annoying issue and could cause unexpected
> behavior. An example is:
> on the customize wizard, if a user edits the disk and saves it, it could
> create a very large disk (1000 PiB) without attention.

create a new bug https://bugzilla.redhat.com/show_bug.cgi?id=2054950 for the disk modal because the current fix of this bug won't take care of it.

Comment 7 Guohua Ouyang 2022-02-23 11:10:19 UTC
Created attachment 1862928 [details]
disk unit on customize wizard

Tested on master, the disk unit is still 'B' if the template has no boot source.
Another problem the disk unit even uses 'B' after modifying it with other values.

Comment 10 Guohua Ouyang 2022-02-28 01:47:56 UTC
Tests should cover three scenarios:
1. create VM from template has no boot source
2. create VM from template has manual updated boot source
3. create VM from template which has auto-updated boot source

Test on master which has the PR included, the first 2 scenarios are PASS, but failed on the scenario 3.

Comment 11 Guohua Ouyang 2022-03-23 05:53:54 UTC
This bug is similar with https://bugzilla.redhat.com/show_bug.cgi?id=2054950
And not reproduced on latest master

Comment 13 errata-xmlrpc 2022-08-10 10:44:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069